Conversation
What was broken The previous fix limited My Challenges to ACTIVE challenges with an open Submission phase. Registered members therefore lost challenges once submission closed even though the challenge remained ACTIVE for review. Root cause The public-list phase filter added in PR #7243 was also applied to the member-scoped My Challenges request. The existing memberId filter already identifies registered challenges, so currentPhaseName over-restricted the results. What was changed Removed the Submission phase constraint only from My Challenges. Kept the ACTIVE status and memberId filters, and retained the Submission filters for All and the total count so scheduled and later-phase challenges remain excluded from the public live list. Any added/updated tests Updated the action regression test to require ACTIVE status and memberId while explicitly verifying that currentPhaseName is omitted. The existing All and total-count tests continue to cover their Submission filters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
PR #7243 prevented scheduled and later-phase challenges from appearing in the live list by requiring an open Submission phase for All, My Challenges, and the total count. QA found that registered members then lost their still-ACTIVE challenges from My Challenges as soon as submission closed and review began.
Root cause
The public-list phase filter was also applied to the member-scoped My Challenges request. That request already uses memberId to identify the member's registered challenges, so currentPhaseName over-restricted the results.
What was changed
Removed the Submission phase constraint only from My Challenges while retaining its ACTIVE status and memberId filters. Kept the Submission filters for All and the total count so scheduled and later-phase challenges remain excluded from the public live list.
Any added/updated tests
Updated the action regression test to require ACTIVE status and memberId for My Challenges and explicitly verify that currentPhaseName is omitted. Existing action tests continue to verify the Submission filter for All and the total count.
Validation completed successfully:
npm run jest -- __tests__/shared/actions/challenge-listing/index.js— 3 tests passednpm run lintnpm run buildnpm test— 151 test suites, 322 tests, and 141 snapshots passed