Revert PR #7249 and subsequent changes - #7256
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Comment on lines
+88
to
+91
| 'Login form filled with values: username - ' + | ||
| username + | ||
| ', password - ' + | ||
| password |
| }); | ||
|
|
||
| /* Update votes on article. */ | ||
| routes.use('/:spaceName/:environment/votes', (req, res, next) => authenticator(authenticatorOptions)(req, res, next), (req, res, next) => { |
| routes.options('/jobs/cache/flush', cors(protectedCorsOptions)); | ||
| routes.get('/jobs/cache/flush', cors(protectedCorsOptions), sensitiveRouteLimiter, configuredJwtAuthenticator, (req, res, next) => new RecruitCRMService().getJobsCacheFlush(req, res, next)); | ||
| routes.options('/jobs/cache/flush', cors()); | ||
| routes.get('/jobs/cache/flush', cors(), (req, res, next) => authenticator(authenticatorOptions)(req, res, next), (req, res, next) => new RecruitCRMService().getJobsCacheFlush(req, res, next)); |
| }; | ||
| routes.options('/jobs/:id/apply', cors(applyOptions)); | ||
| routes.post('/jobs/:id/apply', cors(applyOptions), sensitiveRouteLimiter, configuredJwtAuthenticator, upload.single('resume'), (req, res, next) => new RecruitCRMService().applyForJob(req, res, next)); | ||
| routes.post('/jobs/:id/apply', cors(applyOptions), (req, res, next) => authenticator(authenticatorOptions)(req, res, next), upload.single('resume'), (req, res, next) => new RecruitCRMService().applyForJob(req, res, next)); |
| routes.get('/profile', cors(protectedCorsOptions), sensitiveRouteLimiter, configuredJwtAuthenticator, (req, res, next) => new RecruitCRMService().getProfile(req, res, next)); | ||
| routes.post('/profile', cors(protectedCorsOptions), sensitiveRouteLimiter, configuredJwtAuthenticator, upload.single('resume'), (req, res, next) => new RecruitCRMService().updateProfile(req, res, next)); | ||
| routes.options('/profile', cors()); | ||
| routes.get('/profile', cors(), (req, res, next) => authenticator(authenticatorOptions)(req, res, next), (req, res, next) => new RecruitCRMService().getProfile(req, res, next)); |
| return sharp(body, { limitInputPixels: 40000000 }) | ||
| .resize(size, size, { fit: 'inside' }) | ||
| const u = url && url.startsWith('/') ? `${config.URL.BASE}/${url}` : url; | ||
| const img = await fetch(u); |
| if (selectedFilter.name !== 'Author') { | ||
| window.location.href = `${config.TC_EDU_BASE_PATH}${config.TC_EDU_SEARCH_PATH}?${qs.stringify(searchQuery)}`; | ||
| } else { | ||
| window.location.href = `${config.TC_EDU_BASE_PATH}${config.TC_EDU_SEARCH_PATH}?author=${_.trim(inputlVal)}`; |
| } catch (e) { | ||
| return false; | ||
| } | ||
| return /^(?:(?:(?:https?|ftp):)?\/\/)(?:\S+(?::\S*)?@)?(?:(?!(?:10|127)(?:\.\d{1,3}){3})(?!(?:169\.254|192\.168)(?:\.\d{1,3}){2})(?!172\.(?:1[6-9]|2\d|3[0-1])(?:\.\d{1,3}){2})(?:[1-9]\d?|1\d\d|2[01]\d|22[0-3])(?:\.(?:1?\d{1,2}|2[0-4]\d|25[0-5])){2}(?:\.(?:[1-9]\d?|1\d\d|2[0-4]\d|25[0-4]))|(?:(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)(?:\.(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)*(?:\.(?:[a-z\u00a1-\uffff]{2,})))(?::\d{2,5})?(?:[/?#]\S*)?$/i.test(url); /* eslint-disable-line no-useless-escape */ |
|
|
||
| const applyOptions = { | ||
| ...protectedCorsOptions, | ||
| origin: true, |
| const getCardProps = (deadline, index) => { | ||
| let { name } = deadline; | ||
| let showRange = true; | ||
| name = name.replace(/\bCheckpoint\b/, 'Checkpoint'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
2b97cc0.c819b488918c87b7385fc85b8252aaf6c68e1274, merged by PM-5488: Keep active registered challenges in My Challenges #7248 as8d9fb2dbd7897241534538fdf4f972ce26601314.Why
The 2026 security update rollout and all changes made after the requested cutoff need to be backed out while retaining the registered active-challenge behavior fixed by #7248.
Impact
After this PR is merged, the repository tree will match
8d9fb2dbd7897241534538fdf4f972ce26601314. Active challenges registered to a member remain visible in My Challenges even after the Submission phase closes.Validation
npm run lintnpm run buildnpm run jest -- __tests__/shared/actions/challenge-listing/index.js8d9fb2dbd7897241534538fdf4f972ce26601314.