Skip to content

PM-5488: Keep active registered challenges in My Challenges #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 1 commit into from
Jul 31, 2026
+3 −3
Merged

PM-5488: Keep active registered challenges in My Challenges #7248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions __tests__/shared/actions/challenge-listing/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('live challenge listing filters', () => {
}));
});

test('only requests My Challenges with an open submission phase', async () => {
test('requests all active challenges registered to the member', async () => {
const action = actions.getMyChallengesDone(
'my-uuid',
0,
Expand All @@ -74,11 +74,12 @@ describe('live challenge listing filters', () => {
expect(mockGetChallenges).toHaveBeenCalledWith(expect.objectContaining({
backendFilter,
frontFilter: expect.objectContaining({
currentPhaseName: 'Submission',
memberId: '123',
status: 'ACTIVE',
}),
}));
expect(mockGetChallenges.mock.calls[0][0].frontFilter)
.not.toHaveProperty('currentPhaseName');
});

test('counts only live challenges with an open submission phase', async () => {
Expand Down
1 change: 0 additions & 1 deletion src/shared/actions/challenge-listing/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ function getMyChallengesDone(uuid, page, backendFilter, tokenV3, frontFilter = {
...frontFilter,
...extractSearchFilter(frontFilter),
status: 'ACTIVE',
currentPhaseName: 'Submission',
memberId: userId,
perPage: PAGE_SIZE,
page: page + 1,
Expand Down
Loading