Add tests and update parameters for templates feature - #706
Open
shubhamsg199 wants to merge 2 commits into
Open
Conversation
2 tasks
shubhamsg199
force-pushed
the
fix-templates-params-followup
branch
from
July 28, 2026 16:26
c0e2f8c to
51f5330
Compare
ekohl
requested changes
Jul 28, 2026
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
Thanks for picking up the parameter changes. IMHO this PR is doing 2 things: change parameters and add tests. The PR title should reflect that. On git commits I'd recommend separating it into 2 separate commits.
shubhamsg199
force-pushed
the
fix-templates-params-followup
branch
from
July 28, 2026 17:11
51f5330 to
8b6fde6
Compare
shubhamsg199
changed the title
shubhamsg199
force-pushed
the
fix-templates-params-followup
branch
from
July 28, 2026 17:40
8b6fde6 to
a77dd82
Compare
stejskalleos
requested changes
Jul 29, 2026
shubhamsg199
force-pushed
the
fix-templates-params-followup
branch
from
July 29, 2026 09:12
a77dd82 to
d1a6bea
Compare
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
Needs re-review
labels
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
shubhamsg199
force-pushed
the
fix-templates-params-followup
branch
from
July 29, 2026 10:13
d1a6bea to
a522d6a
Compare
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
shubhamsg199
force-pushed
the
fix-templates-params-followup
branch
from
July 29, 2026 10:27
a522d6a to
31f7aa9
Compare
jeremylenz
added a commit
to jeremylenz/foremanctl
that referenced
this pull request
Jul 30, 2026
- Assert templates feature present when registration enabled (dependency) - Add skipped test for registration endpoint (awaits PR theforeman#706 curl fix) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2 tasks
jeremylenz
suggested changes
Jul 30, 2026
Comment on lines
+135
to
+137
| # this intentionally uses get_paramiko_host directly, as we want the cert of the quadlet box | ||
| # not the one "server" points at, as that can be the proxy | ||
| quadlet = get_paramiko_host('quadlet') |
Contributor
There was a problem hiding this comment.
Hard-coding quadlet here makes me uneasy. This assumes that there is a box named quadlet that is present, something which is not guaranteed on all foremanctl setups. (for instance, if you use forge deploy-dev --target-host localhost.) Maybe we could add a new --quadlet-hostname CLI option (defaulting to "quadlet")?
Member
Member
There was a problem hiding this comment.
Also, can you even run those tests against a dev setup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
This is a followup PR for #519
What are the changes introduced in this pull request?
Dependency: Added changes from https://github.com/theforeman/foremanctl/pull/703/changes for the tests to work, can be easily rebased once it is merged