Add Registration smart proxy feature (SAT-44972) - #675
Draft
jeremylenz wants to merge 5 commits into
Draft
Conversation
ehelms
reviewed
Jul 17, 2026
2 tasks
Contributor
|
@jeremylenz the #519 has been merged |
Implements host registration through the smart proxy with HTTPS-only support and Templates dependency. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add template_url to templates.yml to satisfy plugin validation requirements. Update registration test to verify feature state instead of hardcoded URL for better test portability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jeremylenz
force-pushed
the
capsule-registration-feature
branch
from
July 29, 2026 18:14
c6c025e to
c8c0484
Compare
- Remove registration from main server CI deploy (belongs only on content proxies) - Change test to verify config file on disk instead of API response Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jeremylenz
marked this pull request as ready for review
July 29, 2026 19:54
Changed test_registration_enabled to test_registration_url to verify the parameter via obsah_params (consistent with test_templates_template_url). Set registration-url in CI workflow for the test. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
stejskalleos
requested changes
Jul 30, 2026
- Assert templates feature present when registration enabled (dependency) - Add skipped test for registration endpoint (awaits PR theforeman#706 curl fix) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jeremylenz
marked this pull request as draft
July 30, 2026 12:40
Contributor
Author
|
@stejskalleos Addressed your comment and added the test as skipped for now. Marking this as draft until #706 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Adds the Registration smart proxy feature for foremanctl (SAT-44972). Registration proxies host registration requests through an external smart proxy to Foreman, enabling hosts to register via their nearest proxy.
Depends on Katello/katello#11807 (Katello-side registration proxy support).
What are the changes introduced in this pull request?
registrationfeature tofeatures.yamlwith a dependency ontemplates(auto-enabled)registration.yml.j2sets:enabled: https--registration-urlparameter for load-balanced proxy setupsregistrationin theforeman-proxy-contentflavor (external smart proxies only — not deployed on the main Foreman server)parameters.mdto document the new parameterstest_foreman_proxy_featuresand config file verification intest_registration_enabledHow to test this pull request
Set up your external smart proxy
Make sure
foremanctlis updated to currentOn Foreman server:
On your external smart proxy machine:
registrationappears in the smart proxy features list/etc/foreman-proxy/settings.d/registration.ymlcontains:enabled: https--registration-url https://loadbalancer.example.comand verify the settingChecklist