Add Templates feature to foreman-proxy by shubhamsg199 · Pull Request #519 · theforeman/foremanctl

shubhamsg199 · 2026-05-25T17:30:50Z

Why are you introducing these changes? (Problem description, related links)

What are the changes introduced in this pull request?

Enable templates feature for foreman-proxy

How to test this pull request

Steps to reproduce:

foremanctl deploy --add-feature templates

Checklist

Tests added/updated (if applicable)
Documentation updated (if applicable)

ehelms · 2026-06-10T21:10:06Z

Does templates need to be in the features.yaml? I do not see how the feature in this PR ensures foreman-proxy gets added.

shubhamsg199 · 2026-06-11T16:43:19Z

Does templates need to be in the features.yaml? I do not see how the feature in this PR ensures foreman-proxy gets added.

Yes, templates is declared in features.yaml under the foreman_proxy key (same pattern as bmc). I don't think we have a way to ensure if foreman-proxy gets added.

shubhamsg199 · 2026-06-11T17:07:20Z

@ehelms Made some updates that ensures foreman-proxy gets added on the feature install. Not sure if that should be part of this PR.

pablomh · 2026-07-03T15:06:43Z

Shouldn't the feature by added to foreman_proxy_base_features?

It's currently the default in foreman-installer: https://github.com/theforeman/foreman-installer/blob/0448d5d129f8fe2ea514cfb7fe90857e0e3f15bd/config/foreman-proxy-content-answers.yaml#L30

ekohl · 2026-07-03T15:22:55Z

@pablomh that's only for the content proxies, not for the normal install. It could be part of the proxy flavor.

jeremylenz · 2026-07-22T16:43:05Z

@shubhamsg199 What is the status here?

shubhamsg199 · 2026-07-24T13:04:18Z

@shubhamsg199 What is the status here?

@jeremylenz Updated the PR, can you take a look?

evgeni · 2026-07-28T06:42:05Z

+
+
+@pytest.mark.feature('templates')
+def test_templates_template_url(obsah_params, server_fqdn):


we'll need #703 (or similar) to make this test work

This tests is currently passing

oh, because you changed it to read the params, not talk to the API to fetch the set value.

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>

stejskalleos

🍏 LGTM 🍏

Code looks clear
All comments should be addressed.
Tests are present

Tested with Packit, shortly:

Running foremanctl deploy --add-feature templates --templates-listen-on http --templates-url http://foremanctl9.vagrant.lan/ does not affect the *-pulp proxy.

Running foremanctl deploy --add-feature foreman-proxy will automatically enable templates on the newly running Foreman proxy service.

Merging as #675 is waiting for it.

ekohl · 2026-07-28T10:18:03Z

+  foreman_proxy_templates_listen_on:
+    parameter: --templates-listen-on
+    help: Templates proxy to listen on https, http, or both.
+    choices:
+      - http
+      - https
+      - both


Why is it needed to expose this? In the old installer we exposed it because it was the way we did, but it was an advanced option. In foremanctl I think shouldn't expose this.

Addressed this in #706

ekohl · 2026-07-28T10:18:26Z

+      - both
+  foreman_proxy_templates_url:
+    parameter: --templates-url
+    help: URL that hosts will use to contact the proxy for provisioning templates (e.g. http://<proxy-fqdn>:8000). Required when templates feature is enabled.


There is a default which implies it isn't required to specify.

Updated in #706

shubhamsg199 self-assigned this May 25, 2026

pr-processor Bot added the Not yet reviewed label May 25, 2026

shubhamsg199 marked this pull request as draft May 25, 2026 17:31

shubhamsg199 force-pushed the templates-feature branch from dcadf66 to 9a7993c Compare May 25, 2026 18:00

ehelms reviewed May 26, 2026

View reviewed changes

Comment thread src/playbooks/deploy/metadata.obsah.yaml Outdated

pr-processor Bot removed the Not yet reviewed label May 26, 2026

shubhamsg199 marked this pull request as ready for review June 3, 2026 09:30

shubhamsg199 force-pushed the templates-feature branch 3 times, most recently from 77b2cc9 to 6be7b5b Compare June 5, 2026 15:23

stejskalleos requested changes Jun 8, 2026

View reviewed changes

Comment thread .github/workflows/test.yml Outdated

pr-processor Bot added the Waiting on contributor label Jun 8, 2026

stejskalleos self-assigned this Jun 8, 2026

shubhamsg199 force-pushed the templates-feature branch from 6be7b5b to 26ddc10 Compare June 8, 2026 08:23

pr-processor Bot added Needs re-review and removed Waiting on contributor labels Jun 8, 2026

shubhamsg199 force-pushed the templates-feature branch from 26ddc10 to 215ec14 Compare June 9, 2026 07:18

pr-processor Bot removed the Needs re-review label Jun 9, 2026

shubhamsg199 force-pushed the templates-feature branch from 215ec14 to c5bb26e Compare June 9, 2026 09:43

shubhamsg199 force-pushed the templates-feature branch 4 times, most recently from 713b3d9 to ded1e9b Compare June 11, 2026 17:00

arvind4501 reviewed Jun 12, 2026

View reviewed changes

Comment thread tests/foreman_proxy_test.py Outdated

shubhamsg199 force-pushed the templates-feature branch 2 times, most recently from f0ba618 to b20b505 Compare June 12, 2026 15:23

evgeni reviewed Jun 15, 2026

View reviewed changes

Comment thread src/filter_plugins/foremanctl.py

pr-processor Bot added the Waiting on contributor label Jun 23, 2026

pablomh mentioned this pull request Jul 3, 2026

Add Registration feature to smart proxy pablomh/foremanctl#28

Open

shubhamsg199 force-pushed the templates-feature branch from 5485068 to dcb008f Compare July 9, 2026 14:12

pr-processor Bot added Needs re-review and removed Waiting on contributor labels Jul 9, 2026

shubhamsg199 force-pushed the templates-feature branch from dcb008f to 748fe93 Compare July 9, 2026 16:13

pr-processor Bot removed the Needs re-review label Jul 9, 2026

jeremylenz mentioned this pull request Jul 17, 2026

Add Registration smart proxy feature (SAT-44972) #675

Draft

2 tasks

shubhamsg199 force-pushed the templates-feature branch 7 times, most recently from 88fc9f7 to 916293d Compare July 24, 2026 12:08

ehelms mentioned this pull request Jul 24, 2026

Container Gateway support #611

Open

2 tasks

evgeni mentioned this pull request Jul 27, 2026

Always use the certs from the quadlet machine in the tests #703

Open

2 tasks

evgeni reviewed Jul 28, 2026

View reviewed changes

shubhamsg199 added 2 commits July 28, 2026 12:22

Add Templates feature to foreman-proxy

74b4794

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>

Fix templates deploy on content proxy by setting templates-url

7eb0af0

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>

shubhamsg199 force-pushed the templates-feature branch from 916293d to 7eb0af0 Compare July 28, 2026 06:56

stejskalleos approved these changes Jul 28, 2026

View reviewed changes

stejskalleos enabled auto-merge (squash) July 28, 2026 08:06

stejskalleos merged commit f3224d4 into theforeman:master Jul 28, 2026
27 of 29 checks passed

ekohl reviewed Jul 28, 2026

View reviewed changes

shubhamsg199 mentioned this pull request Jul 28, 2026

Add tests and update parameters for templates feature #706

Open



		@pytest.mark.feature('templates')
		def test_templates_template_url(obsah_params, server_fqdn):

Uh oh!

Conversation

shubhamsg199 commented May 25, 2026

Why are you introducing these changes? (Problem description, related links)

What are the changes introduced in this pull request?

How to test this pull request

Checklist

Uh oh!

Uh oh!

Uh oh!

ehelms commented Jun 10, 2026

Uh oh!

shubhamsg199 commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubhamsg199 commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pablomh commented Jul 3, 2026

Uh oh!

ekohl commented Jul 3, 2026

Uh oh!

jeremylenz commented Jul 22, 2026

Uh oh!

shubhamsg199 commented Jul 24, 2026

Uh oh!

evgeni Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

shubhamsg199 Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

evgeni Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

stejskalleos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ekohl Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

shubhamsg199 Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

ekohl Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

shubhamsg199 Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

shubhamsg199 commented Jun 11, 2026 •

edited

Loading

shubhamsg199 commented Jun 11, 2026 •

edited

Loading

stejskalleos left a comment •

edited

Loading