Skip to content

ci: split the develop and release pipelines - #368

Merged
MusaMisto merged 2 commits into
releases/r10.0-developfrom
musa/ci/develop-pipeline
Oct 12, 2026
Merged

MusaMisto merged 2 commits into
releases/r10.0-developfrom
musa/ci/develop-pipeline

Conversation

@MusaMisto

@MusaMisto MusaMisto commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Why

releases/r10.0-staging was renamed to releases/r10.0-develop, and no job matched the new name, so pushes to develop built nothing (run #142 was skipped). Before the rename, staging also published to the same simplify9/bitween image (including :latest) and NuGet packages that production uses.

What each branch publishes now

releases/r10.0-develop releases/r10.0 (production)
Image simplify9/bitween-develop:10.0.N + :latest simplify9/bitween:10.0.N + :latest
Chart bitween-develop → charts.sf9.io + GHCR bitween → charts.sf9.io + GHCR
NuGet none Sdk + Adapters
CLI pre-release cli-v10.0.N-dev.<run> cli-v10.0.N (latest) + PyPI/npm SDKs
Tests unit + integration (develop-tests) unit + integration
Deploy playground never
  • charts/develop is charts/default symlinked under the name bitween-develop. Make chart changes only in charts/default.
    • The shared pipeline requires chart-name to match Chart.yaml, and the chart builds the image name from the chart name (deployment.yaml:49). So the develop build needs its own chart name, and its image name follows from it.
    • Helm 4 lints and packages the symlinked chart; this was checked locally.
  • Playground upgrades in place. The deploy keeps the release name bitween and sets nameOverride=bitween. Compared with the current chart, helm template shows the same resource names and selectors; only the chart labels, the container name and the image change.
  • develop-tests runs the tests itself, because the shared pipeline only runs them in its NuGet job, which develop no longer runs. As before, a test failure does not block the deploy.
  • One concurrency queue per branch.
    • The two pipelines still share the patch counter, but they publish nothing under the same name.
    • With one shared queue, a develop push could cancel a release that was waiting in the queue.
  • Manual runs run the pipeline of the branch they are started on. On any other branch, nothing runs.

Before merging

  • Create the Docker Hub repository simplify9/bitween-develop (public, like simplify9/bitween). Make sure the DOCKERHUB_TOKEN token can push to it.

r10.0 gets this workflow file the next time develop is merged into it. Until then, r10.0 keeps releasing with its current file.

Rebased onto develop (af969e6)

The three develop commits by @samerz are kept as they are: the AggregationJob change, replicaCount=2, and the switch of the branch name to develop, which this PR replaces.

One fix to theirs: the # Two: … comment sat inside helm-set-values: |, where it isn't a YAML comment. Every line in that block reaches Helm as --set, and Helm rejects that line with key "# Two: the lab's phase 6 kills one mid-traffic" has no value. The comment now sits above the block. replicaCount=2 is unchanged, and the chart renders with 2 replicas.

Update: production chart on GHCR as well; follow-up after simplify9/.github#189

  • The release now publishes the bitween chart to oci://ghcr.io/simplify9/charts/bitween as well as to ChartMuseum. These are the same versions, mirrored to an immutable OCI registry. The shared repo's README already recommends moving charts to OCI.
  • Develop's own fix, CI: no comments inside helm-set-values (f55ab9c), is kept, along with its comment wording.
  • Follow-up once reusable-service-cicd: rename-chart input; run-tests runs without NuGet .github#189 merges: develop switches to chart-path: ./charts/default with rename-chart: true, and to run-tests inside the shared pipeline. charts/develop and develop-tests are then deleted, leaving one chart directory for both names.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (8)
  • ^main$
  • ^master$
  • ^staging$
  • ^development$
  • ^gigstaging$
  • ^develop$
  • ^releases$
  • ^releases/r10.0$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: simplify9/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0ab44978-2223-43b9-a18c-367f64756f9e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

releases/r10.0-staging was renamed to releases/r10.0-develop, which no job matched, so pushes to
develop built nothing (run 142 skipped). Develop now publishes under its own names, so nothing it
builds can reach clients:

- develop: simplify9/bitween-develop image and the bitween-develop chart (ChartMuseum + GHCR),
  deployed to playground, no NuGet packages. charts/develop is charts/default symlinked under its
  own name, since the chart names the image after itself. The playground release stays bitween
  (nameOverride=bitween), so it upgrades in place: same resource names and selectors.
- develop-tests runs the unit and integration tests, which the reusable only runs in its NuGet job.
- r10.0: unchanged release (bitween chart to ChartMuseum, simplify9/bitween, NuGet, CLI, SDKs).
- One concurrency queue per branch: the two pipelines no longer share a published name, and a
  shared queue let a develop push cancel a pending release.
- Manual runs follow the branch they are started on. CLI pre-releases are -dev.<run>.
@MusaMisto
MusaMisto force-pushed the musa/ci/develop-pipeline branch from 7f2c19b to 6035d45 Compare October 12, 2026 09:32
@MusaMisto
MusaMisto merged commit 4ae009c into releases/r10.0-develop Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant