Repository navigation
ci: split the develop and release pipelines - #368
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (8)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MusaMisto
force-pushed
the
musa/ci/develop-pipeline
branch
from
October 12, 2026 09:11
d4d6fb3 to
7f2c19b
Compare
releases/r10.0-staging was renamed to releases/r10.0-develop, which no job matched, so pushes to develop built nothing (run 142 skipped). Develop now publishes under its own names, so nothing it builds can reach clients: - develop: simplify9/bitween-develop image and the bitween-develop chart (ChartMuseum + GHCR), deployed to playground, no NuGet packages. charts/develop is charts/default symlinked under its own name, since the chart names the image after itself. The playground release stays bitween (nameOverride=bitween), so it upgrades in place: same resource names and selectors. - develop-tests runs the unit and integration tests, which the reusable only runs in its NuGet job. - r10.0: unchanged release (bitween chart to ChartMuseum, simplify9/bitween, NuGet, CLI, SDKs). - One concurrency queue per branch: the two pipelines no longer share a published name, and a shared queue let a develop push cancel a pending release. - Manual runs follow the branch they are started on. CLI pre-releases are -dev.<run>.
MusaMisto
force-pushed
the
musa/ci/develop-pipeline
branch
from
October 12, 2026 09:32
7f2c19b to
6035d45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
releases/r10.0-stagingwas renamed toreleases/r10.0-develop, and no job matched the new name, so pushes to develop built nothing (run #142 was skipped). Before the rename, staging also published to the samesimplify9/bitweenimage (including:latest) and NuGet packages that production uses.What each branch publishes now
releases/r10.0-developreleases/r10.0(production)simplify9/bitween-develop:10.0.N+:latestsimplify9/bitween:10.0.N+:latestbitween-develop→ charts.sf9.io + GHCRbitween→ charts.sf9.io + GHCRcli-v10.0.N-dev.<run>cli-v10.0.N(latest) + PyPI/npm SDKsdevelop-tests)charts/developischarts/defaultsymlinked under the namebitween-develop. Make chart changes only incharts/default.chart-nameto matchChart.yaml, and the chart builds the image name from the chart name (deployment.yaml:49). So the develop build needs its own chart name, and its image name follows from it.bitweenand setsnameOverride=bitween. Compared with the current chart,helm templateshows the same resource names and selectors; only the chart labels, the container name and the image change.develop-testsruns the tests itself, because the shared pipeline only runs them in its NuGet job, which develop no longer runs. As before, a test failure does not block the deploy.Before merging
simplify9/bitween-develop(public, likesimplify9/bitween). Make sure theDOCKERHUB_TOKENtoken can push to it.r10.0 gets this workflow file the next time develop is merged into it. Until then, r10.0 keeps releasing with its current file.
Rebased onto develop (af969e6)
The three develop commits by @samerz are kept as they are: the AggregationJob change,
replicaCount=2, and the switch of the branch name to develop, which this PR replaces.One fix to theirs: the
# Two: …comment sat insidehelm-set-values: |, where it isn't a YAML comment. Every line in that block reaches Helm as--set, and Helm rejects that line withkey "# Two: the lab's phase 6 kills one mid-traffic" has no value. The comment now sits above the block.replicaCount=2is unchanged, and the chart renders with 2 replicas.Update: production chart on GHCR as well; follow-up after simplify9/.github#189
bitweenchart tooci://ghcr.io/simplify9/charts/bitweenas well as to ChartMuseum. These are the same versions, mirrored to an immutable OCI registry. The shared repo's README already recommends moving charts to OCI.CI: no comments inside helm-set-values(f55ab9c), is kept, along with its comment wording.chart-path: ./charts/defaultwithrename-chart: true, and torun-testsinside the shared pipeline.charts/developanddevelop-testsare then deleted, leaving one chart directory for both names.