Skip to content

ci: publish develop from the production chart directory - #370

Merged
MusaMisto merged 1 commit into
releases/r10.0-developfrom
musa/ci/develop-single-chart
Oct 12, 2026
Merged

MusaMisto merged 1 commit into
releases/r10.0-developfrom
musa/ci/develop-single-chart

Conversation

@MusaMisto

Copy link
Copy Markdown
Member

Draft until simplify9/.github#189 is merged. This PR uses that PR's rename-chart input. If it merges first, the develop workflow fails at startup with an unknown-input error and publishes nothing until #189 lands.

Why

Develop and production must ship the same chart. #368 did that with charts/develop: its own Chart.yaml, plus symlinks to charts/default. That left two gaps:

  • charts/develop/Chart.yaml is a second file, and it can drift from production's (dependencies, kubeVersion and so on).
  • charts/develop/values.yaml is a symlink, so an edit meant only for develop silently changes production's values.

What

  • One chart directory. Develop builds charts/default and publishes it as bitween-develop with rename-chart: true, which sets Chart.yaml name: at package time. charts/develop is deleted, so both charts now come from one Chart.yaml, one templates/ and one values.yaml.
  • Tests run in the shared pipeline. Develop sets run-tests and test-projects (refactor: move Rebex license key into BitweenOptions #189 runs them without nuget-projects), so the develop-tests job is gone. As before, a test failure does not block the deploy.
  • Nothing published changes. The image is still simplify9/bitween-develop, the chart is still bitween-develop (ChartMuseum + GHCR), and the playground release is still bitween. The chart package has the same name and content as before.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (8)
  • ^main$
  • ^master$
  • ^staging$
  • ^development$
  • ^gigstaging$
  • ^develop$
  • ^releases$
  • ^releases/r10.0$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: simplify9/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f4c03b52-10d8-4cd5-a8b6-4e84053702c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

rename-chart (simplify9/.github#189) publishes charts/default as bitween-develop, so develop and production ship from one Chart.yaml, one set of templates and one values.yaml and cannot drift. It replaces the symlinked charts/develop, whose own Chart.yaml could drift and whose values.yaml symlink let an edit meant for develop change production. The tests now run inside the shared pipeline (run-tests without nuget-projects, same PR), so develop-tests goes.
@MusaMisto
MusaMisto force-pushed the musa/ci/develop-single-chart branch from 5b6c1f5 to a0569b7 Compare October 12, 2026 11:18
@MusaMisto
MusaMisto marked this pull request as ready for review October 12, 2026 11:19
@MusaMisto
MusaMisto merged commit 2516f36 into releases/r10.0-develop Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant