Repository navigation
ci: publish develop from the production chart directory - #370
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (8)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rename-chart (simplify9/.github#189) publishes charts/default as bitween-develop, so develop and production ship from one Chart.yaml, one set of templates and one values.yaml and cannot drift. It replaces the symlinked charts/develop, whose own Chart.yaml could drift and whose values.yaml symlink let an edit meant for develop change production. The tests now run inside the shared pipeline (run-tests without nuget-projects, same PR), so develop-tests goes.
MusaMisto
force-pushed
the
musa/ci/develop-single-chart
branch
from
October 12, 2026 11:18
5b6c1f5 to
a0569b7
Compare
MusaMisto
marked this pull request as ready for review
October 12, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Develop and production must ship the same chart. #368 did that with
charts/develop: its ownChart.yaml, plus symlinks tocharts/default. That left two gaps:charts/develop/Chart.yamlis a second file, and it can drift from production's (dependencies,kubeVersionand so on).charts/develop/values.yamlis a symlink, so an edit meant only for develop silently changes production's values.What
charts/defaultand publishes it asbitween-developwithrename-chart: true, which setsChart.yamlname:at package time.charts/developis deleted, so both charts now come from oneChart.yaml, onetemplates/and onevalues.yaml.run-testsandtest-projects(refactor: move Rebex license key into BitweenOptions #189 runs them withoutnuget-projects), so thedevelop-testsjob is gone. As before, a test failure does not block the deploy.simplify9/bitween-develop, the chart is stillbitween-develop(ChartMuseum + GHCR), and the playground release is stillbitween. The chart package has the same name and content as before.