Skip to content

style(sidebar): expand sponsorship banner on specific pages - #957

Merged
SteveMacenski merged 3 commits into
ros-navigation:rollingfrom
AJedancov:style/expand-sponsorship-banner
Aug 26, 2026
Merged

style(sidebar): expand sponsorship banner on specific pages#957
SteveMacenski merged 3 commits into
ros-navigation:rollingfrom
AJedancov:style/expand-sponsorship-banner

Conversation

@AJedancov

Copy link
Copy Markdown
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • Added custom metadata property that allows expanding the sponsorship banner on specific pages. The banner will now be displayed by default on pages without a table of contents or when the property is set:

    ---
    expand_sponsorship_banner: true
    ---
    
  • Displayed a full-size banner on the main index pages:

    • Home
    • Robots Using
    • About & Contact

    Note: The banner hides their tables of contents.
    On other main pages, the banner is expanded by default.

  • Simplified logic for display conditions.

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
@SteveMacenski
SteveMacenski merged commit e127b5d into ros-navigation:rolling Aug 26, 2026
5 checks passed
SteveMacenski added a commit that referenced this pull request Aug 26, 2026
…957) (#958)

* style(sidebar): expand sponsorship banner on specific pages (#957)

* style: add metadata property to expand sponsorship banner

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

* refactor: simplify condition logic for expanded banner

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

* refactor: use CSS for display conditions

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

---------

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
(cherry picked from commit e127b5d)

# Conflicts:
#	docs/about_and_contact/index.md
#	docs/index.md
#	docs/robots_using/index.md

* Remove docs/ changes, keep overrides/ only

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Andrei Jedancov <56676753+AJedancov@users.noreply.github.com>
Co-authored-by: SteveMacenski <stevenmacenski@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
SteveMacenski added a commit that referenced this pull request Aug 26, 2026
…957) (#959)

* style(sidebar): expand sponsorship banner on specific pages (#957)

* style: add metadata property to expand sponsorship banner

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

* refactor: simplify condition logic for expanded banner

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

* refactor: use CSS for display conditions

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

---------

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
(cherry picked from commit e127b5d)

# Conflicts:
#	docs/about_and_contact/index.md
#	docs/index.md
#	docs/robots_using/index.md

* Remove docs/ changes, keep overrides/ only

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Andrei Jedancov <56676753+AJedancov@users.noreply.github.com>
Co-authored-by: SteveMacenski <stevenmacenski@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants