style(sidebar): expand sponsorship banner on specific pages (backport #957) - #958
Conversation
* style: add metadata property to expand sponsorship banner Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * refactor: simplify condition logic for expanded banner Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * refactor: use CSS for display conditions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com> (cherry picked from commit e127b5d) # Conflicts: # docs/about_and_contact/index.md # docs/index.md # docs/robots_using/index.md
|
Cherry-pick of e127b5d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@mergify[bot], your PR has failed to build. Please check CI outputs and resolve issues. |
|
@AJedancov this is a good question - we don't need to update the main pages, but does the css and overrides get shared for updating the other pages too? |
Yes, the changes from overrides are applied to every page in the docs. In this case, we only need to merge them. The main pages with metadata will be pulled from the rolling and processed as usual along with others. So they can be deleted (including |
|
Which should be retained, the css or the css and html? |
|
Both css and html files |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Basic Info
Description of contribution in a few bullet points
Added custom metadata property that allows expanding the sponsorship banner on specific pages. The banner will now be displayed by default on pages without a table of contents or when the property is set:
Displayed a full-size banner on the main index pages:
Note: The banner hides their tables of contents.
On other main pages, the banner is expanded by default.
Simplified logic for display conditions.
This is an automatic backport of pull request #957 done by [Mergify](https://mergify.com).