Skip to content

style(sidebar): expand sponsorship banner on specific pages (backport #957) - #958

Merged
SteveMacenski merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-957
Aug 26, 2026
Merged

style(sidebar): expand sponsorship banner on specific pages (backport #957)#958
SteveMacenski merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-957

Conversation

@mergify

@mergify mergify Bot commented Aug 26, 2026

Copy link
Copy Markdown

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • Added custom metadata property that allows expanding the sponsorship banner on specific pages. The banner will now be displayed by default on pages without a table of contents or when the property is set:

    ---
    expand_sponsorship_banner: true
    ---
    
  • Displayed a full-size banner on the main index pages:

    • Home
    • Robots Using
    • About & Contact

    Note: The banner hides their tables of contents.
    On other main pages, the banner is expanded by default.

  • Simplified logic for display conditions.


This is an automatic backport of pull request #957 done by [Mergify](https://mergify.com).

* style: add metadata property to expand sponsorship banner

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

* refactor: simplify condition logic for expanded banner

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

* refactor: use CSS for display conditions

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>

---------

Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
(cherry picked from commit e127b5d)

# Conflicts:
#	docs/about_and_contact/index.md
#	docs/index.md
#	docs/robots_using/index.md
@mergify mergify Bot added the conflicts label Aug 26, 2026
@mergify

mergify Bot commented Aug 26, 2026

Copy link
Copy Markdown
Author

Cherry-pick of e127b5d has failed:

On branch mergify/bp/jazzy/pr-957
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit e127b5d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   overrides/assets/stylesheets/sponsorship_banner.css
	modified:   overrides/main.html

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/about_and_contact/index.md
	deleted by us:   docs/index.md
	deleted by us:   docs/robots_using/index.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify

mergify Bot commented Aug 26, 2026

Copy link
Copy Markdown
Author

@mergify[bot], your PR has failed to build. Please check CI outputs and resolve issues.

@SteveMacenski

Copy link
Copy Markdown
Member

@AJedancov this is a good question - we don't need to update the main pages, but does the css and overrides get shared for updating the other pages too?

@AJedancov

AJedancov commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

we don't need to update the main pages, but does the css and overrides get shared for updating the other pages too?

Yes, the changes from overrides are applied to every page in the docs. In this case, we only need to merge them. The main pages with metadata will be pulled from the rolling and processed as usual along with others. So they can be deleted (including about_and_contact and robots_using directories) to resolve the conflict.

@SteveMacenski

SteveMacenski commented Aug 26, 2026

Copy link
Copy Markdown
Member

Which should be retained, the css or the css and html?

@AJedancov

Copy link
Copy Markdown
Contributor

Both css and html files

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@SteveMacenski
SteveMacenski merged commit 5b4f108 into jazzy Aug 26, 2026
4 of 5 checks passed
@SteveMacenski
SteveMacenski deleted the mergify/bp/jazzy/pr-957 branch August 26, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants