style(sidebar): expand sponsorship banner on specific pages (backport #957) - #959
Merged
Conversation
* style: add metadata property to expand sponsorship banner Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * refactor: simplify condition logic for expanded banner Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * refactor: use CSS for display conditions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com> (cherry picked from commit e127b5d) # Conflicts: # docs/about_and_contact/index.md # docs/index.md # docs/robots_using/index.md
Author
|
Cherry-pick of e127b5d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Author
|
@mergify[bot], your PR has failed to build. Please check CI outputs and resolve issues. |
Member
|
@AJedancov this is a good question - we don't need to update the main pages, but does the css and overrides get shared for updating the other pages too? |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Added custom metadata property that allows expanding the sponsorship banner on specific pages. The banner will now be displayed by default on pages without a table of contents or when the property is set:
Displayed a full-size banner on the main index pages:
Note: The banner hides their tables of contents.
On other main pages, the banner is expanded by default.
Simplified logic for display conditions.
This is an automatic backport of pull request #957 done by [Mergify](https://mergify.com).