[CI] Enable ASAN build properly - #22943
Merged
Merged
Conversation
Test Results 23 files 23 suites 3d 19h 7m 53s ⏱️ For more details on these failures, see this check. Results for commit 9b1661b. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
asan-rdf
branch
3 times, most recently
from
August 5, 2026 07:16
fe70534 to
bd3d738
Compare
silverweed
force-pushed
the
asan-rdf
branch
2 times, most recently
from
August 10, 2026 06:43
8d6fbb1 to
6442c1c
Compare
silverweed
marked this pull request as ready for review
August 10, 2026 12:20
pcanal
reviewed
Aug 10, 2026
This reverts commit d8695be.
There are too many failing tests with it
3 main changes:
1. use an ofstream rather than system("echo >")
2. insert failure points in between the system() calls to have a clearer
error in case of failure
3. make sure the pseudo-devnull file is always removed if necessary
In ROOTTEST_ADD_TEST we have a piece of code that adds the Asan libraries to LD_PRELOAD for python scripts, but it excludes a few special cases. Among these there is driveTabCom.py, which is mentioned explicitly by driveRedirect.py to have a similar functionality (that functionality being driving the root.exe process through a pseudo-interactive tty to test some stuff). For reasons that are not entirely clear to me, these scripts don't want the asan libraries in LD_PRELOAD. Possibly because, not having an `import ROOT`, they don't benefit from the tweaks added by this PR: root-project#11621 which prevents Asan libraries from leaking into the ROOT process. This is just a guess. This change fixes a problem with roottest-root-rint-Redirect, which otherwise fails on Alma10 with: ld.so: object '/usr/lib/gcc/x86_64-redhat-linux/14/libasan.so' from LD_PRELOAD cannot be preloaded (file too short): ignored. Notably, this failure doesn't happen on Archlinux. As far as I can tell, the main difference is that on Alma, libasan.so is actually a linker script redirecting to /usr/lib64/libasan.so.8.0.0, whereas in Arch the preloaded library (/usr/lib/libasan.so in that case) is an actual shared object. To be ascertained whether this fix is the "proper" one, but it surely is in line with the way we fixed driveTabCom.py, so if this is to be revised, that one likely needs to be as well.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #22726, with the following additions: