[ci] fix ASAN build - #22726
Closed
jblomer wants to merge 2 commits into
Closed
Conversation
dpiparo
approved these changes
Jun 29, 2026
Test Results 23 files 23 suites 3d 22h 21m 1s ⏱️ For more details on these failures, see this check. Results for commit c98b2fa. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Jun 29, 2026
jblomer
force-pushed
the
asan-rdf
branch
3 times, most recently
from
July 9, 2026 07:26
120a8c9 to
83f377e
Compare
jblomer
force-pushed
the
asan-rdf
branch
3 times, most recently
from
July 9, 2026 21:39
3edcb4b to
c98b2fa
Compare
hageboeck
requested changes
Jul 27, 2026
| @@ -1,11 +1,10 @@ | |||
| CMAKE_BUILD_TYPE=Debug | |||
| CMAKE_CXX_FLAGS_DEBUG="-Og -g" | |||
| CMAKE_BUILD_TYPE=RelWithDebugInfo | |||
Member
There was a problem hiding this comment.
I believe this should be called RelWithDebInfo if it's supposed to have an effect.
Currently, this leads to a build without any optimisation flags or debug options.
This was referenced Jul 28, 2026
Contributor
Author
|
Replaced by #22943 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that we weren't running ASAN builds so far. This PR should fix it. Also change the build type to
RelWithDebugInfo.