[CI] Enable ASAN build properly

.github/workflows/root-ci-config/buildconfig/alma10-asan.txt

@@ -0,0 +1,12 @@
+CMAKE_BUILD_TYPE=RelWithDebInfo
+asan=ON
+ccache=ON
+builtin_civetweb=ON
+builtin_vdt=ON
+ccache=ON
+fail-on-missing=ON
+minimal=ON
+roottest=ON
+testing=ON
+LSAN_OPTIONS=verbosity=1:log_threads=1
+ROOT_CTEST_CUSTOM_FLAGS="-E \(gtest-core-metacling-TClingTest$\|roottest-cling-specialobj-runf02$\|roottest-root-collection-DeleteWarning$\|roottest-root-io-evolution-fixarr2$\|roottest-root-meta-rlibmap$\|roottest-root-tree-cloning-runtreeCloneTest2$\|roottest-root-treeproxy-vectorint-vectorint$\)"

.github/workflows/root-ci.yml

@@ -157,7 +157,7 @@
         env:
           GITHUB_PR_ORIGIN: ${{ github.event.pull_request.head.repo.clone_url }}
           OVERRIDES: ${{ join( matrix.overrides, ' ') }}
         run: |
           [ -d "${VIRTUAL_ENV_DIR}" ] && source ${VIRTUAL_ENV_DIR}/bin/activate
           echo "Python is now $(which python3) $(python3 --version)"
           src/.github/workflows/root-ci-config/build_root.py  \
@@ -300,7 +300,7 @@
           INCREMENTAL: ${{ !contains(github.event.pull_request.labels.*.name, 'clean build') }}
           GITHUB_PR_ORIGIN: ${{ github.event.pull_request.head.repo.clone_url }}
         shell: cmd
         run: "C:\\setenv.bat ${{ matrix.target_arch }} &&
               python .github/workflows/root-ci-config/build_root.py
                     --buildtype       ${{ matrix.config }}
                     --platform        windows10
@@ -430,10 +430,10 @@
             overrides: ["CMAKE_CXX_STANDARD=20"]
           # Asan build
           - image: alma10
-            platform_config: alma10-minimal
+            platform_config: alma10-asan
             is_special: true
             property: "asan"
-            overrides: ["ROOT_CTEST_CUSTOM_FLAGS=-E@\\(^tutorial-\\|cppinterop-CppInterOpTest\\|roottest-cling-specialobj-runf02$\\|roottest-root-collection-DeleteWarning$\\|roottest-root-io-evolution-fixarr2$\\|roottest-root-meta-rlibmap$\\|roottest-root-treeproxy-vectorint-vectorint$\\)"]
+            overrides: ["ROOT_CTEST_CUSTOM_FLAGS=-E@\\(^tutorial-\\|gtest-core-metacling-TClingTest$\\|roottest-cling-specialobj-runf02$\\|roottest-root-collection-DeleteWarning$\\|roottest-root-io-evolution-fixarr2$\\|roottest-root-meta-rlibmap$\\|roottest-root-tree-cloning-runtreeCloneTest2$\\|roottest-root-treeproxy-vectorint-vectorint$\\)"]
           # Fedora Rawhide with Python freethreading+debug build
           - image: rawhide
             python_venv: "/py-venv-3.15td/ROOT-CI"
@@ -467,7 +467,7 @@
       - self-hosted
       - linux
       - ${{ matrix.architecture == null && 'x64' || matrix.architecture }}
       - ${{ matrix.extra-runs-on == null && 'cpu' || matrix.extra-runs-on }}
 
     name: |
       ${{ matrix.image }} ${{ matrix.property }}

cmake/modules/RootMacros.cmake

@@ -1777,6 +1777,7 @@ function(ROOT_ADD_TEST test)
     list(FILTER theCommand INCLUDE REGEX "^-DCMD=.*python[0-9.]*[\\^]")
     if((theCommand AND
         NOT (_command MATCHES XMLParsing/parseXMLs.py OR
+             _command MATCHES roottest/root/rint/driveRedirect.py OR
              _command MATCHES roottest/root/rint/driveTabCom.py))
        OR (_command MATCHES roottest/python/cmdLineUtils AND
            NOT _command MATCHES MakeNameCyclesRootmvInput))

core/base/src/TSystem.cxx

@@ -2593,38 +2593,44 @@ static void R__WriteDependencyFile(const TString & build_loc, const TString &dep
    // standard include directories,
 
    bool needToUnlinkTempFile = false;
-#ifndef WIN32
-   const char * stderrfile = "/dev/null";
-#else
+   TString devnullfile = "/dev/null";
+#ifdef WIN32
    // Determine the null device based on the shell in use.
    // COMSPEC unset or pointing to cmd.exe -> NUL
    // COMSPEC pointing to powershell       -> $null
    // Anything else (e.g. bash/sh on Windows) -> `depfilename`.stderr.tmp
-   TString stderrfile;
    const char *comspec = gSystem->Getenv("COMSPEC");
    if (!comspec || !comspec[0]) {
-      stderrfile = "NUL";
+      devnullfile = "NUL";
    } else {
       TString comspecStr(comspec);
       comspecStr.ToLower();
       if (comspecStr.EndsWith("cmd.exe")) {
-         stderrfile = "NUL";
+         devnullfile = "NUL";
       } else if (comspecStr.Contains("powershell.exe")) {
-         stderrfile = "$null";
+         devnullfile = "$null";
       } else {
          needToUnlinkTempFile = true;
-         stderrfile = depfilename + ".stderr.tmp";
-         gSystem->PrependPathName(build_loc, stderrfile);
+         devnullfile = depfilename + ".stderr.tmp";
+         gSystem->PrependPathName(build_loc, devnullfile);
       }
    }
 #endif
    TString bakdepfilename = depfilename + ".bak";
 
-#ifdef WIN32
-   TString touch = "echo # > "; touch += "\"" + depfilename + "\"";
-#else
-   TString touch = "echo > "; touch += "\"" + depfilename + "\"";
-#endif
+   struct Defer {
+      bool fNeedToUnlinkTempFile;
+      const TString &fDevNullFile, &fBakdepfilename;
+      ~Defer()
+      {
+         if (fNeedToUnlinkTempFile) {
+            // Remove the temporary stderr file if it was created.
+            gSystem->Unlink(fDevNullFile);
+         }
+         gSystem->Unlink(fBakdepfilename);
+      }
+   } deferGuard{needToUnlinkTempFile, devnullfile, bakdepfilename};
+
    TString builddep = "rmkdepend";
    gSystem->PrependPathName(TROOT::GetBinDir(), builddep);
    builddep += " \"-f";
@@ -2675,10 +2681,10 @@ static void R__WriteDependencyFile(const TString & build_loc, const TString &dep
    builddep += "-t";
    R__AddPath(builddep, targetname);
    builddep += "\" > ";
-   builddep += stderrfile;
+   builddep += devnullfile;
    builddep += " 2>&1 ";
 
-   TString adddictdep = "echo ";
+   TString adddictdep;
    R__AddPath(adddictdep,targetname);
    adddictdep += ": ";
 #if defined(R__HAS_CLING_DICTVERSION)
@@ -2694,19 +2700,27 @@ static void R__WriteDependencyFile(const TString & build_loc, const TString &dep
    }
 #endif
    {
-     const char *dictHeaders[] = { "RVersion.h", "ROOT/RConfig.hxx", "TClass.h",
-       "TDictAttributeMap.h","TInterpreter.h","TROOT.h","TBuffer.h",
-       "TMemberInspector.h","TError.h","RtypesImp.h","TIsAProxy.h",
-       "TFileMergeInfo.h","TCollectionProxyInfo.h"};
-
-      for (unsigned int h=0; h < sizeof(dictHeaders)/sizeof(dictHeaders[0]); ++h)
-      {
-         char *rootVersion = gSystem->Which(incPath,dictHeaders[h]);
+      constexpr const char *dictHeaders[] = {"RVersion.h",
+                                             "ROOT/RConfig.hxx",
+                                             "TClass.h",
+                                             "TDictAttributeMap.h",
+                                             "TInterpreter.h",
+                                             "TROOT.h",
+                                             "TBuffer.h",
+                                             "TMemberInspector.h",
+                                             "TError.h",
+                                             "RtypesImp.h",
+                                             "TIsAProxy.h",
+                                             "TFileMergeInfo.h",
+                                             "TCollectionProxyInfo.h"};
+
+      for (const char *header : dictHeaders) {
+         char *rootVersion = gSystem->Which(incPath, header);
          if (rootVersion) {
             R__AddPath(adddictdep,rootVersion);
             delete [] rootVersion;
          } else {
-            R__AddPath(adddictdep,rootsysInclude + "/" + dictHeaders[h]);
+            R__AddPath(adddictdep, rootsysInclude + "/" + header);
          }
          adddictdep += " ";
       }
@@ -2720,32 +2734,36 @@ static void R__WriteDependencyFile(const TString & build_loc, const TString &dep
          delete [] rootCling;
       }
    }
-   adddictdep += " >> \""+depfilename+"\"";
 
-   TString addversiondep( "echo ");
-   addversiondep += libname + version_var_prefix + " \"" + ROOT_RELEASE + "\" >> \""+depfilename+"\"";
+   {
+      std::ofstream depFile(depfilename, std::ios::out | std::ios::trunc);
+      if (!depFile) {
+         ::Warning("ACLiC", "Failed to open dependency file %s for %s", depfilename.Data(), library.Data());
+         return;
+      }
+#ifdef WIN32
+      depFile << "#\n";
+#endif
+   }
 
-   if (gDebug > 4)  {
-      ::Info("ACLiC", "%s", touch.Data());
+   if (gDebug > 4) {
       ::Info("ACLiC", "%s", builddep.Data());
       ::Info("ACLiC", "%s", adddictdep.Data());
    }
+   bool depbuiltOk = !gSystem->Exec(builddep);
+   if (!depbuiltOk) {
+      ::Warning("ACLiC", "Failed to run rmkdepend for %s", library.Data());
+      return;
+   }
 
-   Int_t depbuilt = !gSystem->Exec(touch);
-   if (depbuilt) depbuilt = !gSystem->Exec(builddep);
-   if (depbuilt) depbuilt = !gSystem->Exec(adddictdep);
-   if (depbuilt) depbuilt = !gSystem->Exec(addversiondep);
-
-   if (!depbuilt) {
-      ::Warning("ACLiC","Failed to generate the dependency file for %s",
+   std::ofstream depFile(depfilename, std::ios::out | std::ios::app);
+   if (!depFile) {
+      ::Warning("ACLiC", "Failed to open dependency file %s for %s after running rmkdepend", depfilename.Data(),
                 library.Data());
-   } else {
-      if (needToUnlinkTempFile) {
-         // Remove the temporary stderr file if it was created.
-         gSystem->Unlink(stderrfile);
-      }
-      gSystem->Unlink(bakdepfilename);
+      return;
    }
+   depFile << adddictdep << "\n";
+   depFile << libname << version_var_prefix << " \"" << ROOT_RELEASE << "\"\n";
 }
 
 ////////////////////////////////////////////////////////////////////////////////

core/sanitizer/SanitizerSetup.cxx

@@ -32,7 +32,7 @@ const char* __asan_default_options() {
          ":alloc_dealloc_mismatch=0"
          DETECT_LEAKS
          ":verify_asan_link_order=0"
-         ":halt_on_error=0";
+         ":detect_odr_violation=0";
 }
 
 /// Default options when leak sanitizer starts up in ROOT executables.

roottest/root/io/heritstl/SEIdAltLItem.h

@@ -34,10 +34,10 @@ class SEIdAltLItem {
       fSigLin(siglin), fSigCorr(sigcorr),
       fTime(time) { };
 
-   SEIdAltLItem(const SEIdAltLItem& that) // copy ctor
-      { *this = that; }
+   SEIdAltLItem(const SEIdAltLItem &) = default;
+   SEIdAltLItem &operator=(const SEIdAltLItem &) = default;
 
-   virtual ~SEIdAltLItem() { ; } // dtor
+   virtual ~SEIdAltLItem() = default;
 
    Int_t          GetSEId() const { return fStripEndId; }
    Float_t        GetWeight() const { return fWeight; }