feat(matching): 共通フィクスチャと照合コアに仕向地「デンソー」を追加する (#107) - #113
Merged
Merged
Conversation
…nd both matching cores Adds Destination.denso / DENSO with a generic parser for the JAMA self-describing kanban QR (header length, item descriptor list, exact data-length check, required items 104/112/152), probes it before the lenient sawai/molten checks, validates the 6-4@code product tag, formats Denso part numbers as 6-4, and keys the box identity on the QR alone. The shared fixture grows from 35 to 47 cases with the seven real kanban/tag pairs plus cross-destination mismatches, and three denso test images are generated. Sawai and molten behaviour is unchanged. Refs #107
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107 (parent #106).
変更
shared/test-fixtures/matching-cases.json: 35 → 47 ケース。デンソーのかんばん 7 組（Vision デコードの 221 文字 JAMA 自己記述レコード）+ 別品番・隣品番・澤井ラベル・モルテンラベル・澤井 QR × デンソーラベルの不一致 5 件。schemaVersionは 2 のまま。テスト画像denso-*.png3 点を生成。ScanModels.swift:Destination.denso、DensoKanbanRecord（ヘッダ長・項目定義・データ部桁合計の汎用解析、必須項目 104/112/152、項目番号重複の拒否）、detectは denso を先に判定（寛容なKanbanQRRecord.parseがJAMA501195…をカード番号として通すため）、TagBarcodeRecordの仕向地別パターン（denso6-4、未確定は 3 つの OR）、format(partNumber:destination:)（denso 10 桁 →6-4）、BoxIdentityは QR 全文。Localizable.xcstringsにデンソー/Denso。core/model・core/matching:DENSO("denso")、DensoKanbanQrRecord（Swift と同一規則）、detectDestination・expectedQrLength(): Int?・boxIdentity・partNumberFromQr・formatPartNumber(_, destination)・TagBarcodeRecord.isValidScanPayload(_, Destination?)。enum 追加で壊れるwhen3 箇所とscan_destination_denso/history_destination_denso（ja/en）、HistoryExportLabels.destinationDenso。テスト
lintDebug testDebugUnitTest: 432 tests, 0 failuresCodeMatchTests: 141 tests, 0 failures🤖 Generated with Claude Code