feat(android-scan): 読取フローをデンソーのかんばんに対応させる (#110) - #114
Merged
Merged
Conversation
The reducer classifies an unparseable QR in a Denso-locked session (and any unlocked JAMA-prefixed payload) as invalid without a length hint, validates Code 128 against the nullable locked destination instead of defaulting to Sawai, formats Denso part numbers as 6-4 on the result card and in the recorded code, and guards the Molten delivery summary behind the destination lock. Sawai and Molten behaviour is unchanged. Refs #110
rimtty
force-pushed
the
codex/denso-android-scan
branch
from
September 7, 2026 12:52
022952f to
e098c62
Compare
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110 (parent #106). Builds on #113.
変更
ScanReducer: 不正 QR の分類を「判定成功 → デンソーロック中は長さ案内なしで INVALID → 既存の 66/61 判定 →JAMA先頭は INVALID → 既存の未ロック 57–66 判定」の順に。Code 128 の検証はlockedDestination（null 可）を渡し、?: SAWAIの既定を削除。observedQrLengthはデンソーでも空白込み。recordedCodeは QR の仕向地で整形（デンソーは6-4）。ScanState:RecordedBox.fromPayloadsの整形に仕向地を渡す。moltenResultSummaryにdestination == MOLTENガード。ScanSessionCoordinator: カメラ Code 128 のスタビライザ前検証にstate.destination（null 可）を渡す。ScanScreen: 結果カードの品番 2 箇所を仕向地付きで整形。ScanViewModel: デモ用定数SAMPLE_DENSO_QR_PAYLOAD/SAMPLE_DENSO_BARCODE_PAYLOAD（runDemoは澤井のまま）。unlockedInvalidQrLengths…/moltenLockedInvalidQrLengths…は無変更で緑）。テスト
ScanReducerTest+8、ScanCheckpointMappingTest+1、ScanSessionCoordinatorTest+1、ScanScreenTest+1、AppFlowInstrumentationTest.fakeScannerDensoFlowCountsBoxesPerPartNumberAndLocksDestination、ScanViewModelCheckpointInstrumentationTest.densoDestinationLockSurvivesIsolatedDatabaseReopenlintDebug testDebugUnitTest: 442 tests, 0 failures。:app:assembleRelease成功。Pixel 7 で:feature:scan:connectedDebugAndroidTest30 件緑（app の計測は CI エミュレーターで実行）。🤖 Generated with Claude Code