feat(ios-history): 履歴詳細と PDF にデンソーのかんばん項目を記載する (#109) - #117
Merged
Merged
Conversation
The history detail and the PDF choose the record by destination instead of the lenient Kanban parse, add a Denso section with the kanban fields (form type, part number as 6-4, packaging, pack quantity, next process, instruction, kanban serial, management number, delivery date, run, instructed quantity, item number, receiving code) and print the kanban serial with every box. The 1-argument format(partNumber:) overload is removed so every caller names its destination. Sawai and Molten output is unchanged. Refs #109
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109 (parent #106). Builds on #113 / #115.
変更
HistoryModels.swift:MatchHistoryEntry.densoRecord（Destination.detect == .densoガード。寛容なKanbanQRRecord.parseがデンソーの QR を澤井として通すため、表示側は必ず仕向地ガード付きのプロパティを使う）。HistoryScreen.swift:MatchEntryDetailをkanbanRecord→moltenRecord→densoRecordの分岐にし、デンソーは 13 項目（帳票区分・部品番号6-4・包装・収容数・次区・指示・かんばん連番・管理番号・納入日・便・指示数・アイテムNo・受入。無い項目は行ごと省略）。箱の行にはデンソーでも管理コードを表示。SessionPDFExporter.swift: デンソーはかんばん 3 行 + 各箱にかんばん連番。澤井のブロックはentry.kanbanRecord経由に（出力は不変）。ScanModels.swift: 1 引数のformat(partNumber:)を削除し、全呼び出しが仕向地を明示。Localizable.xcstrings: 14 キー（ja 明示 + en）。テスト
SessionPDFExporterTests.testDensoSessionPrintsKanbanBlockAndBoxes（カード番号と納品番号数が出ないことも断言）、HistoryExporterTests.testDensoSessionExportsDestinationId、HistoryStoreTests.testDensoRecordParsesFromEntry、UI テストを履歴詳細まで延長（仕向地、デンソー・かんばん連番）。CodeMatchTests: 156 tests, 0 failures（ja と-testLanguage en -testRegion USの両方）。UI テスト緑。🤖 Generated with Claude Code