Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified demo/e2e/screenshot.spec.ts-snapshots/radio-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/e2e/screenshot.spec.ts-snapshots/radio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 16 additions & 0 deletions demo/src/app/index/pages/radio/radio.page.html
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,20 @@ <h2>radio</h2>
<ion-item><ion-radio value="error-b">Error option B</ion-radio></ion-item>
</ion-radio-group>
</ion-list>

<ion-radio-group value="voice-1">
<ion-list [inset]="true">
<ion-item-group>
<ion-item><ion-radio value="system-default">System default</ion-radio></ion-item>
</ion-item-group>
</ion-list>

<ion-list [inset]="true">
<ion-list-header><ion-label>Radio Group Across Lists</ion-label></ion-list-header>
<ion-item-group>
<ion-item><ion-radio value="voice-1">Voice 1</ion-radio></ion-item>
<ion-item><ion-radio value="voice-2">Voice 2</ion-radio></ion-item>
</ion-item-group>
</ion-list>
</ion-radio-group>
</ion-content>
8 changes: 8 additions & 0 deletions demo/src/app/index/pages/radio/radio.page.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,12 @@ describe('RadioPage', () => {
it('should create', () => {
expect(component).toBeTruthy();
});

it('should demonstrate one radio group across multiple inset lists', () => {
const radioGroup = fixture.nativeElement.querySelector('ion-radio-group:has(> ion-list)');

expect(radioGroup).not.toBeNull();
expect(radioGroup.querySelectorAll(':scope > ion-list')).toHaveLength(2);
expect(radioGroup.querySelectorAll(':scope > ion-list > ion-item-group')).toHaveLength(2);
});
});
2 changes: 2 additions & 0 deletions demo/src/app/index/pages/radio/radio.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
IonItemGroup,
IonLabel,
IonList,
IonListHeader,
IonRadio,
IonRadioGroup,
IonText,
Expand All @@ -35,6 +36,7 @@ import {
IonItemGroup,
IonLabel,
IonList,
IonListHeader,
IonText,
IonRadioGroup,
IonRadio,
Expand Down
2 changes: 1 addition & 1 deletion src/styles/components/ion-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ion-list.list-inset.ios:not(.ios26-disabled) {
padding-inline-end: calc(var(--ion-safe-area-right, 0) + 20px);
}

:is(#{structured-list.$groups}):not(:is(#{structured-list.$groups}) :is(#{structured-list.$groups})) {
> :is(#{structured-list.$groups}) {
ion-item {
// To draw lines inside
--inner-padding-end: 0;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/utils/structured-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ $groups: ion-item-group, ion-reorder-group, ion-accordion-group, ion-radio-group
}
}

:is(#{$groups}):not(:is(#{$groups}) :is(#{$groups})) {
> :is(#{$groups}) {
display: block;
border-radius: $group-border-radius;
overflow: hidden;
Expand Down
Loading