Skip to content

fix: support radio groups across inset lists - #131

Merged
rdlabo merged 6 commits into
mainfrom
fix/radio-group-across-lists
Aug 31, 2026
Merged

fix: support radio groups across inset lists#131
rdlabo merged 6 commits into
mainfrom
fix/radio-group-across-lists

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • scope inset-list group styling to direct children of each ion-list
  • preserve a single styled boundary for nested structured groups
  • add a radio demo covering one group across multiple inset lists

Verification

  • npm run build
  • radio page unit tests
  • Prettier checks for the changed files

Closes #129

@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  90 passed

Details

stats  90 tests across 2 suites
duration  1 minute, 56 seconds
commit  842b773
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-131/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-131/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 29, 2026
@rdlabo

rdlabo commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-131/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-131/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 30, 2026
@rdlabo

rdlabo commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

/beta

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-131/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 30, 2026
@rdlabo

rdlabo commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

/beta

@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed and a repository administrator requested /beta for commit 8d96f41c7cb3. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios26@9.0.2-beta.pr131.sha8d96f41c7cb3

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-131/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 30, 2026
@rdlabo
rdlabo merged commit 2aeffc8 into main Aug 31, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in OSS Maintainer Commitments Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit 2aeffc803d78. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios26@9.0.2-beta.pr131.sha2aeffc803d78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Radio Group over multiple lists

1 participant