Repository navigation
Open Watch Party: the protocol crate, its checks and eight conformance tables - #1462
Conversation
A new layer [owp] that names only base (docs/module-layers.md). The crate joins every -p list UNIT_SUITE and the lab check use, and SRC_OWP joins every check-deps.sh gate that lists all the split crates, MACHINES and FORK_SCOPE. The app does not depend on it, so it stays out of HOSTSIM_SUITE, RUST_INPUTS and test_no_host_staticlib.py's LAYER_CRATES. The crate is licensed under Apache-2.0, like Open Watch Party, so it can be used on its own; LICENSING.md says so. The two read-only certificates in ci/proofs are regenerated for the new manifest and lock, with their CERTIFICATE_SHA256 pins. The serde_json one also takes the current lib.rs hashes of ui and play-feed, which changed on main after its last regeneration in bc12623. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
…bers serde_json refuses an unpaired surrogate escape and a number too large for a double, and the vectors hold both. A scan rewrites each such escape to \ufffd and each such number to 0 padded with spaces, keeping the length, and records their ordinals. A serde visitor then marks the string or member name (SDK.md 16.8) and returns the number as +-Infinity, as the SDKs' decoders do. Member order and duplicates are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
…e timeline The checks of SDK.md 3.2, 4, 7.1, 8 and 9.7, the same-title rule of 9.3 and the room position of 8. ci/list-caps.ini gets the sections for every protocol limit of the crate, the clock window and the message size included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
SDK.md 5: pings by id, samples whose round trip is 0 to 1000 ms, the clock step and the window of the 8 newest. ClockSync is in ci/machines.ini, with its outcome as the effect, so ci/test_transition_arguments.py counts 11 machines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
The 17 client messages are built from typed values and checked before sending: bounds, the descriptor checks and 8192 bytes. The 5 relay messages are read with the rules of SDK.md 8 for joined, room, pong, error and closed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
rust-modules/owp/fixtures/ holds files copied unchanged from edde746/openwatchparty at d8c3c2abc753: the Apache-2.0 LICENSE, relays.json, the eight tables this crate implements and the descriptor examples of spec/examples. Its README lists each upstream path and SHA-256, and THIRD-PARTY-NOTICES.md section 6 names it. Every table has a runner, and a guard fails on a vendored table without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
…nore action in joined Three review fixes, each with a test seen failing first: - The reader keeps duplicate member names, so the send checks now refuse a descriptor that repeats one at any depth (SDK.md 7.1); the descriptor examples with repeated names run as send failures instead of being skipped. - The scan rewrites an overflowing number only when the token follows the JSON number grammar, so 01e400, 1.e400 and -.5e400 stay errors. - action in joined.room is an unknown member, as snapshot.schema.json has it, instead of making the joined malformed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
The HOSTSIM_SUITE notes in the Makefile and docs/agent-reference.md name plx_owp among the crates without a hostsim feature, and the hook note says the release-config hook does not watch owp. THIRD-PARTY-NOTICES.md section 6 counts three components, module-layers.md says owp may name only base and names no layer crate today, the source_lines list in ci/build-budgets.json reads right, and strict_json's doc names plx_owp::json as the other reader that keeps duplicates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
GLinnik21 asked in plxnative#1090 for an empty uses on [owp], so the crate can later be used on its own. It already names no plx_* crate; the row and the paragraph in docs/module-layers.md now say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
GLinnik21 asked in plxnative#1090 for a hard failure when the two passes disagree on the marks. read() now also compares the marks the visitor applies and the infinities it returns with the scan's, in read_scanned(), which the tests feed a forged scan. A scan that broke the UTF-8 of its input is an error instead of an empty text. The escaped-backslash cases he named have tests: \\ud83d alone, before a pair, and after an odd run of backslashes. A scan that skips one byte after a backslash turns them red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
GLinnik21 asked in plxnative#1090 for a cap checked before the scan. decode() now returns TooLarge for a message over MAX_RELAY_MESSAGE_BYTES, 65536 bytes, without reading it. SPEC.md §3.1 makes 32768 the least a client accepts, and the Dart and Kotlin SDKs test past it, so the cap is above that floor; the value is the one proposed in plxnative#1090 and waits for his answer. The 32768 test now reads messages of exactly 32768, 40000 and 65536 bytes. ci/list-caps.ini classes the cap as not-a-list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
GLinnik21 asked in plxnative#1090 for tests on real message parsing as well as the tables. decode() now has them for unknown members at two depths, escaped names and values, lone surrogates in a checked field and in an unknown one, numbers past their range (1e400 and 2^53, and 1e400 inside ext), ext nested 100 levels deep (read) and 5000 (Ignored at serde_json's recursion limit), and unknown error codes, closed reasons and action kinds, which stay strings. This commit also carries one rule: a relay message that repeats a member name at any depth is Malformed("repeated name"). SPEC.md §4 forbids sending one but says nothing of receiving it; refusing it means no copy is chosen. Each test was seen red: the repeated names before the rule, the others under a mutation of the code they guard, except the escapes, which serde_json decodes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
GLinnik21 asked in plxnative#1090 for a fuzz target in this PR: same length, no panic, ordinals agree. owp_json checks, on any UTF-8 input: - json::scanned, the scan's facts made public for it, keeps the length; - decode and read do not panic, and read never fails with DISAGREEMENT, the error a split between the scan and the visitor gives; - what serde_json reads, the reader reads too, with no marks; - the strings the visitor marks and the numbers it makes infinite, in document order, are the ordinals the scan recorded. Seen red: a visitor that leaves a member name unmarked is found in 6 s, a scan that skips one byte after a backslash in 3 s. The seeds are the vendored examples and relays.json plus six relay messages; owp.dict holds the message names, the surrogate escapes and the overflowing numbers. fuzz.yml runs it for changes under rust-modules/owp and counts ten targets; the Makefile's disk note and docs/agent-reference.md give its 49 MiB. DISK_NEED stays 3.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
CONTRIBUTING.md, TRADEMARKS.md and the README's licence line said all of the project's own code is GPL-3.0-or-later; plx_owp is now Apache-2.0, as LICENSING.md says. Found by doc-claim-auditor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
pr-reviewer: decode returned Malformed("repeated name") before reading type,
so the session could not tell a malformed joined, which SDK.md §8 answers
with leave and a failed join, from a malformed pong, which it ignores; and
an unknown type or a non-object with a repeated name came back Malformed,
where SDK.md says those are ignored. decode now reads type first: a repeated
name gives Malformed(<type>) for the five relay types and Ignored otherwise.
Both tests failed against the previous order.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
pr-reviewer: without float_roundtrip, serde_json reads 1.79769313486231581e308 as f64::MAX, while the scan rounds it correctly to Infinity, as JavaScript does; the target crashed on it against a correct reader. It now asserts only that an input serde_json reads has no marks. The token joins the overflow seed, and a json.rs test pins it as Infinity (red when the scan stops rewriting overflowing numbers). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
main's three new commits re-pinned ci/proofs/platform-generated-enums.json for a doc-only variant of FirstInGroupAnimated; the branch had re-pinned it for the plx_owp manifest. ci/readonly_generated.py took main's side, and scripts/plxnative-certs.sh regenerated both certificates and their CERTIFICATE_SHA256 pins on the merged tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
GLinnik21
left a comment
There was a problem hiding this comment.
The 64 KiB pre-scan limit looks good. I ran the 56 crate tests and checked the public API directly. Two behaviors need fixes before the session machine builds on them. I left inline comments on both. Two smaller protocol gaps to keep in view are that the media validator loses the first failed rule required by SDK §9.7, and PingId only represents integer numeric IDs even though SPEC §7.4 permits a string or number. The latter does not affect the integer IDs generated by the SDK clock.
GLinnik21 on plxnative#1462: SDK.md §4.1 has relayFor and formatCode share one normalizer, and relayFor returns null for an invalid code. relay_for took the first character as given, so with the embedded list "K" routed to asia and the valid "k7m-q2x" to nothing. The code-routing runner normalized before calling it, so the table missed both. relay_for now normalizes and validates the whole input, the runner passes the code as typed, and the tests call relay_for directly. The new tests and the table failed against the previous relay_for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
GLinnik21 on plxnative#1462: SDK.md §9.7 says unknown members outside ext are not checked, not kept and not sent. joined_media returned the checked descriptor whole, so media.futureField reached Incoming::Joined. It now returns media::known_members, which drops unknown members at the top level and in series and file, and keeps ext and every ids namespace whole. The test failed against the previous joined_media. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
GLinnik21 on plxnative#1462: SDK.md §9.7 has checkMedia return the first rule a descriptor breaks, so that an app can trim file.name or ext and check again (SDK.md:1244). check returned a bool. It now returns Result<(), MediaRule>: one rule per member, in the order the TypeScript SDK checks them, then the send-only rules, a repeated name, ext over 1024 bytes and the descriptor over 4096. The tests did not compile against the bool, and four mutations of the order, the mapping and the direction turn them red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Thanks for running them. Both inline points are fixed, and answered in their threads. On the two smaller gaps:
On d8c9599: |
|
@claude review |
|
Claude finished @GLinnik21's task in 2m 18s —— View job ReviewNothing blocking in
|
|
|
||
| fn valid_action(action: &Json) -> bool { | ||
| action.members().is_some() | ||
| && action.get("kind").and_then(Json::as_text).is_some_and(|text| !text.value.is_empty()) |
There was a problem hiding this comment.
action.kind only has to be non-empty, so "kind":"\ud800" passes as "\u{fffd}", while closed.reason and error.code go through plain_string and refuse it. The room-check table doesn't cover it and I can't see SDK.md from here, so this is a question: should kind also need !text.unpaired?
There was a problem hiding this comment.
No. SDK.md:433 asks only for a non-empty string, and TypeScript checks no more (messages.ts:136). The difference ran the other way: error and closed refused a lone surrogate, which SDK.md:492-493 doesn't ask for. So a closed whose reason held one was dropped here, while TypeScript ends the party (party.ts:908). Fixed in b31411e: error.code, message, re and closed.reason now take the text with U+FFFD. The test failed against the old decode, and it also pins kind.
The review on plxnative#1462: valid_url tested the /v1/ws ending on the whole URL, so the // of the scheme could supply its slash, and wss://v1/ws (host v1, path /ws) passed. SDK.md §3.2 wants the ending after a non-empty host. The ending is now tested on the part after the scheme, as the TypeScript SDK does (relaylist.ts:43). The new test failed against the previous valid_url. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
…reads them The review on plxnative#1462 asked whether action.kind should refuse an unpaired surrogate, as error.code and closed.reason did. SDK.md §8 asks of an action kind only a non-empty string (SDK.md:433), and of an error and a closed only strings, with code and reason non-empty (SDK.md:492-493). The TypeScript SDK reads them so (messages.ts:136, party.ts:908). kind stays as it is. error.code, error.message, error.re and closed.reason now take the text the reader made, with U+FFFD for the surrogate, where they were Malformed before: a closed whose reason is "kicked" plus a lone surrogate ends the party in TypeScript, and was dropped here. The new test failed against the previous decode; it also pins kind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
The review on plxnative#1462: an entry left the clock's map of sent pings only when its pong arrived, so each ping the relay never answered stayed for the life of the ClockSync. Each PingSent now first drops the pings sent more than 10 s before, as the TypeScript SDK does (clock.ts:13 and :22). No outcome changes: a pong later than LARGEST_RTT_MS was already ignored. The new test failed against the previous transition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
The review on plxnative#1462: resume, transferHost and kick sent peerId and token unchecked, though the PR says every client message is checked before sending; only the 8192-byte cap stopped a bad one. They now go through is_peer_id and is_token, the receive patterns, and fail with InvalidMessage("peerId") or InvalidMessage("token"). is_token reads the Json, as is_peer_id does. The participant check of SDK.md §12 (SDK.md:973-974) is the session's. The new test failed against the previous encode. The 8192-byte test now pads a ping's text id, the one client string with no bound of its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
The review on plxnative#1462: the reader turns a number past a double's range into an infinity, and a received descriptor may carry one inside ext, where values are any JSON. Written back, serde_json makes it null, so re-sending that descriptor would change it without an error. The send check now has MediaRule::ExtNumber after the repeated name and before the ext size, as the Swift SDK's checkMedia refuses "a number JSON can't carry" (Media.swift:296); the receive check is unchanged. Json gains holds_a_non_finite_number. The new test failed against the previous check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filippo Scatigna <filippo@scatigna.tech>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
The five points of the On daefc2c: |
Third of the four PRs agreed in #1090: the OWP messages and their validation, in a new sans-IO crate
plx_owp. Nothing in the application names it yet. The session machine is the fourth PR; the integration and the UX come after, as agreed.What is in it
rust-modules/owp/, mounted asowp, in a new layer[owp] uses =that names no other layer (docs/module-layers.md). It depends onserdeandserde_jsononly, both already in the graph, names noplx_*crate, and is licensed under Apache-2.0 from its first commit;LICENSING.mdsays so.json: the reader. A scan rewrites each unpaired surrogate escape to�, and each number too large for a double to0padded with spaces. Both keep the length, and the scan records their ordinals. Aserdevisitor then marks the string or member name, and returns ±Infinity for the number, as the SDKs' decoders do (conformance/vectors/tools/check.go:115). Only tokens that follow the JSON number grammar are rewritten. Member order and duplicates are kept, so the send checks can refuse a repeated name.serde_jsonbesideui::rec::strict_json, whose doc now says so.strict_jsoncan't serve:uisits aboveowp, and it refuses the surrogates and the overflowing numbers.text,code,relays,media,room,timeline: the checks of SDK.md §3.2, §4, §7.1, §8 and §9.3/§9.7, and the room position of §8.clock: the clock sync of §5, registered inci/machines.ini(transition, effectPongOutcome).message:checkMedia, no repeated member name, 8192 bytes;joined,room,pong,errorandclosed.actioninjoined.roomis an unknown member, assnapshot.schema.jsonhas it.Your answers in #1090
Layer and licence: as above.
The reader stays in
plx_owp:\\ud83dis text,\\ud83d\ude00marks only the lone low half, and\\\ud83dis an escape. Each has a test.decodereturnsTooLargefor a message overMAX_RELAY_MESSAGE_BYTESbefore the scan. The cap is 65536, as agreed in the thread, because SPEC.md §3.1 makes 32768 a floor.ext100 levels deep (read) and 5000 (refused at serde_json's recursion limit), and unknown error codes, closed reasons and action kinds, which stay strings, with U+FFFD for a lone surrogate (SDK.md §8).One choice of mine to check: a relay message of one of the five relay types that repeats a member name at any depth is
Malformed(<type>), so the session still answers it by type (SDK.md §8); an unknown type or a non-object staysIgnored. SPEC.md §4 forbids sending a repeated name but says nothing of receiving one. Refusing it means no copy is chosen; TypeScript'sJSON.parsewould keep the last one.Examples: the 46 files are vendored, and §6 of
THIRD-PARTY-NOTICES.mdnames them.Fuzz:
owp_json, infuzz/beside the other nine. On any UTF-8 input:json::scannedkeeps the length;decodeandreaddon't panic;readnever fails withDISAGREEMENT;float_roundtrip, serde_json reads1.79769313486231581e308asf64::MAX, where the scan rounds it to Infinity as JavaScript does; ajson.rstest pins that token;Seen red first: a visitor that leaves a member name unmarked is found in 6 s, and a scan that skips one byte after a backslash in 3 s. On the code here, 300 s ran 3 897 561 inputs with no crash (coverage 2327). The seeds are the vendored examples,
relays.jsonand six relay messages.fuzz.ymlruns it for changes underrust-modules/owp/; the tree grows by 49 MiB, soDISK_NEEDstays 3.3.Vendored data
rust-modules/owp/fixtures/is copied unchanged from edde746/openwatchparty atd8c3c2abc753. It holds:LICENSE(Apache-2.0);relays.json, also embedded as the public list;descriptor.*andsetMedia.*examples ofspec/examples/.Its
README.mdlists each file's upstream path and SHA-256, andTHIRD-PARTY-NOTICES.md§6 has the line you asked for.Lists and certificates
UNIT_SUITEand every-plist name the crate.HOSTSIM_SUITE,RUST_INPUTSandtest_no_host_staticlib.py'sLAYER_CRATESdon't, because the app doesn't reach it.ci/check-deps.shreads it asSRC_OWPin every gate that lists all the split crates, and inMACHINESandFORK_SCOPE.ci/list-caps.inihas the 14 sectionscheck-list-caps.pyasked for: 12 protocol limits (format), the display grouping of a room code and the inbound cap (not-a-list).ci/proofs/serde-json-immutable.jsonandci/proofs/platform-generated-enums.jsonare regenerated, and bothCERTIFICATE_SHA256pins are updated.ci/readonly_dependencies.py --produce, run on the cachedserde_json-1.0.154.crate, whose SHA-256 matches the lock. The platform one comes fromreadonly_generated.produce_certificate.lib_sha256ofui/src/lib.rsandplay-feed/src/lib.rs. Both changed onmainafter its last regeneration inbc126230.mainis merged in atdab26adb. Its re-pin of the platform certificate conflicted with this branch's; both certificates were regenerated on the merged tree.ci/test_transition_arguments.pynow counts 11 machines, andci/test_build_bench.py's fake test build listsplx_owp.Tests
67 tests in
plx_owp.The eight tables pass 516 of 516 cases.
every_vendored_table_has_a_runnerfails on a table without a runner.Each runner seen red. I broke one rule at a time, and its table failed:
ws://in the public list;ext;The descriptor examples: 13 valid pass
checkMedia, and 31 invalid fail it. The three with repeated names are among the 31. Only the invalid UTF-8 files are left out, since they can't reach a parsed value.SDK.md §17's own tests that fall here:
TooLarge;relays.json.Every new test was seen failing first: against the old code where it adds a rule, and otherwise under a mutation of the code it guards (an escape skipped one byte short, unpaired text accepted, ints past 2^53, a closed list of error codes or action kinds, a participant with no room for unknown members, an unreadable message made malformed, overflowing numbers left unrewritten). The escapes test is the exception: serde_json decodes them.
The review fixes each came with a test seen failing first:
extorids;01e400,1.e400and-.5e400refused;actioninjoined.room;Your review's fixes, each with tests seen failing first:
relay_fornormalizes the typed code, tested directly and through the table;joinedkeeps only the known members of its descriptor;media::checkreturns the first rule a descriptor breaks, red under four mutations of the order, the mapping and the direction.The
claudereview's fixes, each with a test seen failing first, and red under eight mutations of the fixes:/v1/wsafter its host;errorandclosedstrings keep a lone surrogate as U+FFFD, as SDK.md §8 and TypeScript read them;peerIdandtokenare checked before sending;extis not sent, as in Swift.Checks
On
daefc2c0, with both reviews fixed, WSL2 x86_64:make checkis clean: 35 suites, 22935 passed, 0 failed, 239 ignored, and 143 of 143 steps ok, 135 of them Python.make check-nodefandmake lintare clean.cargo check --lib --target armv7-unknown-linux-gnueabi -p plx_owpis clean, except for the usualneon/soft-floatnotes.python3 ci/check-build-budgets.py --graphstays at 93 packages, because members don't count.make build-bench, base9f5ff482against1d735102, the branch before the merge ofmain(whose three commits don't touchplx_owp), 3 runs each:plx_basecbuf.rsplx_machinelandgate.rsplx_platformdevcaps.rsplx_gfxoverdraw.rsplx_netstream_redirect.rsplx_uidwell.rsplx_plexretry.rsplx_telemetrywindow.rsplx_datatape.rsplx_sessionscripted.rsplx_mediaunits.rsplx_appkitskip_pill.rsplx_screensclock_readout.rsplx_uilib.rsplx_basecbuf.rs, incrementalplx_uilib.rs, incrementalplx_owp.plx_owp, so I read those five as noise. Two other scenarios came out below the base's min: scripted and units.a5d84423, every branch median was within the base's range or below it.pr-reviewer, first round on the first eight commits, raised 3 MAJOR and 2 MINOR:strict_json: explained above, andstrict_json's doc fixed;actioninjoined: fixed.doc-claim-auditorraised 6 prose findings, all fixed: theHOSTSIM_SUITEnotes, the hook note indocs/agent-reference.md, §6's count, "names only base", a list inci/build-budgets.jsonand the examples' wording.Second round, on the changes for your answers:
pr-reviewer: 0 BLOCKER, 0 MAJOR, 2 MINOR, both fixed. The repeated-name tag now carries the message type, and the fuzz target no longer compares infinities with serde_json (see Fuzz above).doc-claim-auditor: 4 findings. Three are fixed:CONTRIBUTING.md,TRADEMARKS.mdand the README's licence line now name the Apache-2.0 exception. The fourth, PR16's paragraph indocs/hud-plugins.md, lists the targets of that PR. It lackedws_framebefore this branch, so I left it.Not covered
party.json: the fourth PR, on the same vectors revision.🤖 Generated with Claude Code