Skip to content

CI: Claude reviews like umputun's review skill, and may diff against main - #1470

Merged
GLinnik21 merged 1 commit into
mainfrom
ci/claude-review-style
Nov 19, 2026
Merged

GLinnik21 merged 1 commit into
mainfrom
ci/claude-review-style

Conversation

@GLinnik21

Copy link
Copy Markdown
Collaborator

Claude now reviews the way umputun's review skill does (umputun/cc-thingz, plugins/review). That skill is built to avoid the usual review-bot noise.

What the new instruction tells Claude

  • Read the conversation first. That means every earlier comment, inline thread and bot review. It never raises a point that's already resolved or that a maintainer already made, and keeps a bot finding only if it checked it itself.
  • See the whole change. It runs git fetch origin main, adding --deepen=200 if there's no merge base, then git diff origin/main...HEAD. Last time it couldn't diff the Makefile, ci/ list or certificate changes.
  • Read the PR's CI results instead of running tests. On a fork, tests would run the contributor's code next to the token.
  • What to look for: real bugs, missing error handling, code that doesn't match the patterns around it, over-engineering (saying what simpler thing would do), and changes unrelated to the PR's purpose.
  • Output:
    • findings inline, one or two sentences each, with a suggestion block when the fix is small;
    • the summary is lgtm, or a short numbered list with file:line;
    • casual tone, no recap, no headings, no praise, no sign-off, and none of the usual AI words.

Permissions: read-only git is now allowed in both jobs: git fetch origin, git diff, git log and git show. Fable runs without auto mode, so any command that isn't allowed is refused, which is why git fetch failed on #1462. These commands only read history. On fork PRs, git hooks and fsmonitor are already off, and git -c or env-var prefixes don't match the allow rules.

Checks

  • ci/test_ci_timeouts.py: OK.
  • ci/test_ci_workflows.py: 103 tests OK.

Build bench: not applicable. This is a mention-only workflow and no build input changed.

🤖 Generated with Claude Code

…main

Replace the style prompt with the rules of umputun's review skill: read the
whole conversation first and never repeat a settled point, verify bot findings,
diff against main, read CI instead of running tests, look for bugs, pattern
breaks, over-engineering and unrelated changes, findings inline, a summary that
is lgtm or a short numbered list, no recap, praise or AI filler. Allow
read-only git (fetch origin, diff, log, show) in both jobs for the diff: Fable
runs without auto mode, so unlisted commands are refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@GLinnik21
GLinnik21 merged commit 41007e6 into main Nov 19, 2026
9 checks passed
@GLinnik21
GLinnik21 deleted the ci/claude-review-style branch November 19, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant