Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
dc3a9bd
Open Watch Party: register the plx_owp crate in the workspace
PilaScat Nov 18, 2026
d1f0f84
OWP: a JSON reader that keeps unpaired surrogates and overflowing num…
PilaScat Nov 18, 2026
651175c
OWP: names, room codes, the relay list, descriptors, snapshots and th…
PilaScat Nov 18, 2026
b4f02ee
OWP: the clock sync as a registered machine
PilaScat Nov 18, 2026
e1e4575
OWP: the message codec
PilaScat Nov 18, 2026
b3cc348
OWP: vendored conformance data and the table runners
PilaScat Nov 18, 2026
7e8ce43
OWP: refuse repeated names before sending, read only JSON numbers, ig…
PilaScat Nov 18, 2026
f703707
Docs: correct the prose the plx_owp crate made false
PilaScat Nov 18, 2026
007e5b7
OWP: the layer names no other layer
PilaScat Nov 18, 2026
0946da3
OWP: the reader fails when the scan and the visitor disagree
PilaScat Nov 18, 2026
173a952
OWP: decode caps a relay message before the scan
PilaScat Nov 18, 2026
8918094
OWP: decode tested on real relay messages; repeated names are malformed
PilaScat Nov 18, 2026
8f6d8f9
Fuzz: owp_json over the Open Watch Party reader
PilaScat Nov 18, 2026
56b3583
Docs: name the Apache-2.0 exception where the licence is stated
PilaScat Nov 18, 2026
465eac7
OWP: a repeated member name is malformed under its message type
PilaScat Nov 18, 2026
1d73510
Fuzz: owp_json compares only the marks with serde_json
PilaScat Nov 18, 2026
59a0bc6
Merge upstream main (dab26adb) into feat/owp-protocol
PilaScat Nov 18, 2026
3146f5c
OWP: relay_for normalizes the typed code before it routes
PilaScat Nov 18, 2026
38ecd9a
OWP: a received joined descriptor keeps only its known members
PilaScat Nov 18, 2026
d8c9599
OWP: media::check names the first rule a descriptor breaks
PilaScat Nov 18, 2026
b6a8a74
OWP: a relay URL needs /v1/ws after its host
PilaScat Nov 19, 2026
b31411e
OWP: error and closed strings may carry a lone surrogate, as the SDK …
PilaScat Nov 19, 2026
67f45fd
OWP: the clock forgets a ping unanswered for 10 s
PilaScat Nov 19, 2026
16f1f5e
OWP: peerId and token are checked before sending
PilaScat Nov 19, 2026
daefc2c
OWP: a descriptor with a non-finite number in ext is not sent
PilaScat Nov 19, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/skills/which-tier/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ but a photograph could show it (`gfx.rs`, at the `glBlendFuncSeparate` call).

### Tier 1 — `make check`

`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens`, preceded by `make lint` (three **named** clippy lints —
`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp`, preceded by `make lint` (three **named** clippy lints —
`ifs_same_cond`, `same_functions_in_if_condition`, `if_same_then_else` — the shadowed-branch gate),
and followed by **three** host checks that are easy to forget are in here: `python3 ci/flavor.py
--selftest` (the flavour transform, whose central assertion is that the STABLE transform is the
Expand Down Expand Up @@ -108,7 +108,7 @@ lock.) Do not write a new number here: measure it if you need one — this file
Count it yourself if you need the number:

```sh
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -- --list | grep -c ': test'
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp -- --list | grep -c ': test'
```

**Run it on the pinned toolchain.** `make check` uses `cargo +$(RUST_TOOLCHAIN)`, the `channel` of
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ jobs:
# (`cargo metadata` resolves; it compiles nothing), plus an informational line count.
# The binary-size budget runs in cross-build, where the binary exists. Limits and how to
# raise one deliberately: ci/build-budgets.json, docs/agent-reference.md.
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/platform/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/platform/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src --src rust-modules/owp/src

- name: Third-party notices vs the ARM runtime graph
# `make check` runs only the OFFLINE half of this (ci/gen-third-party-notices.py --check), which
Expand Down Expand Up @@ -309,7 +309,7 @@ jobs:
# for plxnative-modules both ways), so the `cargo test --lib` below finds everything built
# and this step is where the compile happens, not an extra one. The upload below carries it.
shell: bash
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens --no-run --timings
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp --no-run --timings

- name: make check-cargo-unit-default
# Teed to a file so the size step below can read the `test result:` lines this run already
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/fuzz.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Fuzz the HUD parsers

# The `cargo fuzz` package in `fuzz/` (docs/hud-plugins.md, "Fuzzing"): one libFuzzer target over each parser
# a HUD package or the registry reaches, and one over the WebSocket codec (`plx_net::ws`). It is not part of
# a HUD package or the registry reaches, one over the WebSocket codec (`plx_net::ws`) and one over the Open
# Watch Party reader (`plx_owp::json`). It is not part of
# the rust-modules workspace, so nothing in `ci.yml`
# compiles it; this workflow is what keeps it from rotting, and the only place it is fuzzed for longer than
# a smoke test.
Expand Down Expand Up @@ -50,6 +51,8 @@ on:
- 'rust-modules/net/src/ws/**'
- 'rust-modules/base/src/sha1.rs'
- 'rust-modules/base/src/b64.rs'
- 'rust-modules/owp/src/**'
- 'rust-modules/owp/fixtures/**'
- 'rust-modules/build_support/host_link.rs'
- 'rust-modules/Cargo.lock'
- 'site/hud/schema/**'
Expand All @@ -59,11 +62,11 @@ on:
workflow_dispatch:
inputs:
secs:
description: 'Seconds per target (9 targets run one after another; the step stops at 100 minutes)'
description: 'Seconds per target (10 targets run one after another; the step stops at 100 minutes)'
type: string
default: '300'
target:
description: 'One target (admit, bundle_read, archive_read, svg_check, address_parse, catalog_parse, catalog_verify, catalog_cache, ws_frame); empty runs all'
description: 'One target (admit, bundle_read, archive_read, svg_check, address_parse, catalog_parse, catalog_verify, catalog_cache, ws_frame, owp_json); empty runs all'
type: string
default: ''

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Contributing

New contributions to PlxNative's own code are offered under GPL-3.0-or-later, without copyright
assignment. Retain existing third-party notices and identify external code, its source revision,
assignment; to `rust-modules/owp/` (`plx_owp`), under Apache-2.0, as `LICENSING.md` says. Retain existing third-party notices and identify external code, its source revision,
license and modifications. Do not submit code whose redistribution rights you cannot establish.

Please include a `Signed-off-by: Your Name <email>` trailer certifying the
Expand Down
2 changes: 2 additions & 0 deletions LICENSING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
Copyright (c) 2026 Gleb Linnik and contributors.
PlxNative's own code is licensed under the GNU General Public License, version 3 or
(at your option) any later version: **GPL-3.0-or-later**. The complete license is in `LICENSE`.
The `plx_owp` crate (`rust-modules/owp/`) is the exception: it is licensed under **Apache-2.0**, like
Open Watch Party, so it can be used on its own. That license is in `licenses/Apache-2.0.txt`.
There is no warranty, to the extent permitted by applicable law.

You may use, modify and redistribute this software, including selling copies, under those terms.
Expand Down
19 changes: 10 additions & 9 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1555,8 +1555,9 @@ DISK_TREE = $(if $(CARGO_TARGET_DIR),$(if $(filter /%,$(CARGO_TARGET_DIR)),$(CAR
DISK_NEED =
test-fast test-crate: DISK_TREE = $(CURDIR)/rust-modules/$(TEST_FAST_TDIR)
test-hostsim: DISK_TREE = $(CURDIR)/rust-modules/$(TEST_HOSTSIM_TDIR)
# The fuzz tree (ASan + coverage, release with debuginfo, nine binaries): 3.1 GiB measured after a cold build
# of the first eight; the ninth, `ws_frame`, adds 83 MiB (measured on Linux x86_64).
# The fuzz tree (ASan + coverage, release with debuginfo, ten binaries): 3.1 GiB measured after a cold build
# of the first eight; the ninth, `ws_frame`, adds 83 MiB, and the tenth, `owp_json`, 49 MiB with `plx_owp`
# (measured on Linux x86_64).
fuzz-hud: DISK_TREE = $(CURDIR)/rust-modules/$(FUZZ_TDIR)
fuzz-hud: DISK_NEED = 3.3
check-replay sim-macos: DISK_TREE = $(abspath $(SIM_TDIR)$(if $(LAB),-lab,))
Expand Down Expand Up @@ -1679,7 +1680,7 @@ check-cargo-lint: lint
@# gate has nothing to reuse a cache for. No `pkg/lab.json` is involved — that file is `make
@# LAB=1`'s requirement (a live session secret), not the compiler's.
@set -e; cd rust-modules && CARGO_INCREMENTAL=0 PATH="$$HOME/.cargo/bin:$$PATH" \
cargo +$(RUST_TOOLCHAIN) check --lib --tests -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens --features lab-diagnostics
cargo +$(RUST_TOOLCHAIN) check --lib --tests -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp --features lab-diagnostics
@# And the demo-video dump build's pixel oracle, `placeholder-sentinel`: in no default set and
@# built only by `make site-video-sim`, which no gate runs and which compiles no `plx_ui` tests, so
@# this line is what keeps it compiling (its code AND its tests, `--tests`). `plx_ui` is the only
Expand All @@ -1698,11 +1699,11 @@ check-cargo-lint: lint
# `-p` lists in the recipes below (those stay literal because ci/test_ci_split.py greps for them);
# ci/test_test_crate.py pins the two equal.
UNIT_RUN = python3 ../tools/cargo-test-parallel.py
UNIT_SUITE = plxnative-modules plx_base plx_machine plx_platform plx_gfx plx_net plx_ui plx_plex plx_telemetry plx_data plx_session plx_media plx_playback_contract plx_play_uri plx_play_feed plx_media_codecs plx_appkit plx_screens
UNIT_SUITE = plxnative-modules plx_base plx_machine plx_platform plx_gfx plx_net plx_ui plx_plex plx_telemetry plx_data plx_session plx_media plx_playback_contract plx_play_uri plx_play_feed plx_media_codecs plx_appkit plx_screens plx_owp
# The `hostsim` pass runs only the crates that DECLARE a `hostsim` feature (HOSTSIM_SUITE, a subset of
# UNIT_SUITE in the same order; ci/test_test_crate.py pins both the subset and the recipe). The seven that
# do not (plx_net, plx_ui, plx_appkit, plx_screens, plx_media_codecs, plx_play_uri, plx_playback_contract)
# have no `feature = "hostsim"` in their source and the same test names in both passes (14 crates did in
# UNIT_SUITE in the same order; ci/test_test_crate.py pins both the subset and the recipe). The eight that
# do not (plx_net, plx_ui, plx_appkit, plx_screens, plx_media_codecs, plx_play_uri, plx_playback_contract,
# plx_owp) have no `feature = "hostsim"` in their source and the same test names in both passes (14 crates did in
# CI run 43528579834; the three that differ are `plxnative-modules`, `plx_media` and `plx_play_feed`,
# all kept). Their own test set is therefore identical in the two passes. The old second run did link
# their test binaries against hostsim-built `plx_base`, `plx_gfx`, `plx_platform`, `plx_media` and
Expand Down Expand Up @@ -1739,7 +1740,7 @@ check-cargo-unit-default:
cd rust-modules && PATH="$$HOME/.cargo/bin:$$PATH" PLXNATIVE_RUNTIME_DIR="$$d" \
$(TELEMETRY_ENV) \
$(HOST_ENV) \
$(UNIT_RUN) -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens
$(UNIT_RUN) -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp
RUST_TOOLCHAIN=$(RUST_TOOLCHAIN) python3 ci/test_storage_service_package.py
cd rust-modules && PATH="$$HOME/.cargo/bin:$$PATH" cargo +$(RUST_TOOLCHAIN) test -p plxnative-storage --bin plxnative-storage
@# The helper is its own package, so building it compiles no copy of the app library; this reads
Expand Down Expand Up @@ -1797,7 +1798,7 @@ test-fast:
PATH="$$HOME/.cargo/bin:$$PATH" PLXNATIVE_RUNTIME_DIR="$$d" \
$(TELEMETRY_ENV) \
$(HOST_ENV) \
$(UNIT_RUN) $(if $(T),--filter '$(T)') -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens
$(UNIT_RUN) $(if $(T),--filter '$(T)') -- cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_platform -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp

# `make test-crate C=plx_ui [T=filter] [DEPS=1]` -- build and run ONLY the named crate's lib tests, in
# the same incremental `$(TEST_FAST_TDIR)` tree and with the same flags as `test-fast`, so the two
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ Error monitoring for PlxNative is sponsored by [Sentry](https://sentry.io/for/go

## Licence

[GPL-3.0-or-later](LICENSE), © 2026 Gleb Linnik. The PlxNative name and its brand artwork are excluded — see
[GPL-3.0-or-later](LICENSE), © 2026 Gleb Linnik; `rust-modules/owp/` is Apache-2.0 ([`LICENSING.md`](LICENSING.md)). The PlxNative name and its brand artwork are excluded — see
[`TRADEMARKS.md`](TRADEMARKS.md), which also carries the Plex and LG non-affiliation statements.
Third-party components and their licences are in
[`THIRD-PARTY-NOTICES.md`](THIRD-PARTY-NOTICES.md) and `licenses/` — notably the app ships its own
Expand Down
15 changes: 12 additions & 3 deletions THIRD-PARTY-NOTICES.md
Original file line number Diff line number Diff line change
Expand Up @@ -630,11 +630,20 @@ the GPL-3.0-or-later election. Also retain `licenses/GCC-exception-3.1.txt` and

## 6. Deliberately not listed

Two third-party components exist in the PlxNative source repository but are **not** part of this
Three third-party components exist in the PlxNative source repository but are **not** part of this
package, and therefore carry no obligation discharged here: **libjpeg-turbo**
(`libturbojpeg.so.0`, copied to developer televisions by the development deploy step only) and
(`libturbojpeg.so.0`, copied to developer televisions by the development deploy step only),
**jsmpeg** (a host-side development tool; `tools/stream-screen.py` downloads it at the upstream commit
`ci/dependencies.json` pins, so no copy of it is in the repository; its licence is `licenses/jsmpeg.txt`). Neither is present in the installed application.
`ci/dependencies.json` pins, so no copy of it is in the repository; its licence is `licenses/jsmpeg.txt`), and
the **Open Watch Party** conformance data described below. None of the three is present in the installed application.

The Open Watch Party data in `rust-modules/owp/fixtures/` holds test vectors,
descriptor and `setMedia` examples and the public relay list, copied unchanged from
[edde746/openwatchparty](https://github.com/edde746/openwatchparty) at revision `d8c3c2abc753`
(Apache-2.0, its text in `rust-modules/owp/fixtures/LICENSE`, the file list and hashes in that
directory's `README.md`). The `plx_owp` tests read them; the application does not link `plx_owp`, so
none of it is installed. The relay list `relays.json` is compiled into `plx_owp` and moves to §2 when
the application links it.

## Source-only attribution

Expand Down
3 changes: 2 additions & 1 deletion TRADEMARKS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Trademarks, brand assets, and non-affiliation

The [GPL-3.0-or-later grant](LICENSE) covers this project's own source code. This file covers the things a
The [GPL-3.0-or-later grant](LICENSE) covers this project's own source code, except the `plx_owp` crate,
which is Apache-2.0 ([`LICENSING.md`](LICENSING.md)). This file covers the things a
licence grant does not: the marks that identify the project, and whose software this interoperates
with.

Expand Down
2 changes: 1 addition & 1 deletion ci/build-budgets.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"headroom": "+3"
},
"source_lines": {
"what": "Lines of Rust under rust-modules/src, rust-modules/base/src, rust-modules/machine/src, rust-modules/net/src, rust-modules/platform/src, rust-modules/gfx/src, rust-modules/ui/src, rust-modules/plex/src, rust-modules/telemetry/src, rust-modules/data/src, rust-modules/session/src, rust-modules/media/src, rust-modules/playback-contract/src, rust-modules/media-codecs/src, rust-modules/play-feed/src, rust-modules/play-uri/src, rust-modules/appkit/src and rust-modules/screens/src (every .rs file). Informational: exceeding it warns and never fails, because a growing feature is not a build-health defect by itself.",
"what": "Lines of Rust under rust-modules/src, rust-modules/base/src, rust-modules/machine/src, rust-modules/net/src, rust-modules/platform/src, rust-modules/gfx/src, rust-modules/ui/src, rust-modules/plex/src, rust-modules/telemetry/src, rust-modules/data/src, rust-modules/session/src, rust-modules/media/src, rust-modules/playback-contract/src, rust-modules/media-codecs/src, rust-modules/play-feed/src, rust-modules/play-uri/src, rust-modules/appkit/src, rust-modules/screens/src and rust-modules/owp/src (every .rs file). Informational: exceeding it warns and never fails, because a growing feature is not a build-health defect by itself.",
"unit": "lines",
"mode": "warn",
"limit": 485000,
Expand Down
Loading
Loading