Skip to content

refactor(ui): complete owned presentation and replay inputs - #1392

Merged
GLinnik21 merged 3 commits into
mainfrom
ui-owned-fifo-followup-20261114-1145
Nov 15, 2026
Merged

GLinnik21 merged 3 commits into
mainfrom
ui-owned-fifo-followup-20261114-1145

Conversation

@GLinnik21

Copy link
Copy Markdown
Collaborator

Draft scope

Continue the new UI migration on current main, separately from already-merged #1366. No automatic merge or ready-for-review transition is requested.

  • Execute all eleven app-effect families through one owned dispatcher FIFO and taken-head runner, retaining sender lifetime, frozen ReturnState, budgets, cancellation/refusal and exactly-once completion.
  • Capture screen runtime policy, all thirteen effective profile preferences, install/running language and complete immutable player presentation at the app boundary. Controlled hosts use explicit inputs and explicit native-port capability, never ambient diagnostic/preference fallbacks.
  • Bind strict CURRENT V11 bootstrap/writer/reader contracts; reject unknown/noncanonical fields and underspecified unpublished profiles. Refund only dropped scalar-row JSON reservations, without changing peak/retained-data limits.
  • Add targeted source and negative-control gates, captured-policy/runtime tests, strict replay refusal accounting and the exact-byte current Filmography fixture. Existing recording directories and ALPHABET remain unchanged. CURRENT requires SAME; only the approved historical dynamic-Content scheduler profile expects exact early refusal, never a fixture-name/hash exception.

Ownership and integration

Based on main 8859e4bad1838f154a90bbb5885fd48d928c7d72, independently confirmed through origin and GitHub git/ref. The patch was extracted semantically against the recovered source's original base, excluding EOL-only recovery churn and unrelated work, then applied three-way in a separate clean branch/worktree. The source worktree's HEAD, logical index, raw index and tracked bytes are independently checked unchanged.

129 owned paths: 127 from reviewed migration changes plus four newly added paths, minus two excluded paths. Exclusions retain incoming main's outgoing-stop timing fix and the entire original fixture inventory, including its README. No source-tree replacement, old-PR restack, closed-branch push, toolchain/dependency downgrade, private report or local runtime is included. Incoming Rust 1.100.0, dependency identities, Canon optimization and CI timing fixes remain intact. Generated-unit-enum proof adds only the reviewed exact merged machine identity; generator grammar, namespace/writer contracts and negative controls remain strict.

Verification

Exact proposed Git tree f26920af41cd524121f5b725fa909b8fcb25eaab matches the native staged tree and independent Linux mirror. On incoming pinned Rust 1.100.0 / Python 3.12.16, all inherited GIT_* variables removed and bounded two-job Rust execution:

  • Final full make check: PASS, 568.98 seconds. Cargo lint/default/hostsim and Python phases all pass; 136 registered rest steps pass. Harness: 745 tests, OK, four existing skips. Default app 1418/0, screens 2168/0, appkit 955/0, media 2134/0; hostsim app 1621/0 and media 2414/0. Media retains its 100 existing ignored tests.
  • All six final configurations PASS: shipping, bare, play-uri, play-feed, devtriggers and hostsim.
  • Focused current/legacy bootstrap and actual fixture preflight, replay parser 24, fixture/privacy class 13, CI registry 16, generated-proof mutations, UI-boundary controls, FIFO routing and poisoned nested-Git isolation PASS. Full DepGates selector regression PASS after integrating the new rules with main's selector contract.
  • Full-patch outbound/private-path scan and guard controls PASS; native diff whitespace check PASS. All original fixtures and ALPHABET are untouched; added manifest/segment match their officially imported bytes exactly.

Two integration-oracle failures were fixed before the final run: patch export framing at the manifest's absent final newline, and new source rules not yet registered in main's selective gate protocol. Neither fix changes fixture bytes, weakens production policy or relaxes a test. Prior recovered-source software-renderer results (six SAME plus two exact historical refusals) remain separate evidence, not a fresh renderer claim for this integrated tree. Remote exact-head CI, simulator replay and ARM artifacts are pending publication and must be reviewed independently.

Deliberately incomplete acceptance

This is a DRAFT, not whole-project UI acceptance. ARM/native build artifacts require remote CI verification; local SDK is absent. Native TV/video-plane/glyph/performance, accepted accelerated visuals, WSLg transport, the full 70-route scenario matrix, architecture census and cached-modal acceptance remain unverified. Earlier private software-renderer evidence is logical replay evidence only, not hardware or visual approval. No account/provider/TV/system changes or SDK downloads were made.

- Run app commands through the owned FIFO and capture explicit UI presentation inputs.
- Bind strict V11 replay, preserve historical fixtures and enforce boundary regressions.
- Separate request admission from owner-derived visible damage.

- Preserve calendar rails and add idle, request and result regressions.
@GLinnik21
GLinnik21 marked this pull request as ready for review November 15, 2026 23:24
@GLinnik21
GLinnik21 merged commit fe6efc1 into main Nov 15, 2026
18 checks passed
@GLinnik21
GLinnik21 deleted the ui-owned-fifo-followup-20261114-1145 branch November 15, 2026 23:32
fraygox added a commit to fraygox/plx-native that referenced this pull request Nov 16, 2026
main's machine-shape gate (plxnative#1358, plxnative#1392) certifies shared payload types against
two proof files that pin every workspace manifest's hash. This branch adds the
`http3-curlstack` feature to rust-modules/Cargo.toml, base/Cargo.toml and
net/Cargo.toml, so after the merge both certificates were refused and
`ci/check-machine-shape.py` reported the session machine's payloads as opaque
(28 problems), failing five `make check` steps.

Both are regenerated with their own producers
(`ci/readonly_dependencies.py --produce serde_json-1.0.154.crate`,
`readonly_generated.produce_certificate`) and the pinned certificate hashes
updated, as main's own dependency bump did (6d7b48e). The only changes are
those three manifest hashes, plus play-feed's `lib_sha256` in the serde_json
certificate, which the producer refreshed: main's entry predates a later edit
to play-feed/src/lib.rs that this branch does not touch.

Signed-off-by: fraygox <251108859+fraygox@users.noreply.github.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
tiper added a commit to tiper/fin-native that referenced this pull request Nov 16, 2026
Since plxnative#1392 the Playback page reads its settings from the captured inputs, so the
picker test hands Convert audio's stored value in the capture like every other row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JLzd9SJCCZ5zFGv23XMA8h
GLinnik21 added a commit that referenced this pull request Nov 17, 2026
…e no longer blocks its page's command (#1433)

Picking a row in Play Version, or a copy in Also available, on a Detail page closed the panel and did nothing. Since #1392 a page's app commands run at the head of the pre-commit queue, and a surface's Dismiss is only parked until NAV COMMIT, so the closing panel still owned input when the page's ContentReq::Play or Present arrived, and content_command's gate (input_owner() is the sender's entry) refused it.

The dispatcher gains a read-only question, input_owner_after_dismissals: who holds input once the Dismisses already parked this drain commit. ModalStack and Navigation take input_owner_unless(dismissed), and input_owner() delegates to it with nothing dismissed. The five page-command gates in content.rs (content, Home, Search, Watchlist outside SetOptions, Library) go through one holds_input helper. The item menu keeps its own closing_menu gate, a dead sender is still RetiredSender, and a page under a picker that stays open is still refused. A content page presented as a surface that dismisses itself through Back now has a further command in the same drain refused, as it was before #1392.

Tests (red first): a picked version plays that version while its panel is still closing, through the product frame and the real runner; a picked alternative source opens that copy the same way; a page under a picker that stays open is still refused; and a ui containers test for the owner once a surface's Dismiss is parked. No test stacks two real surfaces (the Also available copy with its own Play Version over it); that case was checked by reading.

Closes #1424

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant