Repository navigation
Play Version and Also available act on a pick again: a closing surface no longer blocks its page's command - #1433
Merged
Merged
Conversation
…e no longer blocks its page's command Since #1392 a page's app command runs at the head of the dispatcher FIFO, in the drain ahead of the frame's NAV COMMIT. Play Version and Also available are surfaces that close on a pick and report the row to their Detail page (`Fx::Nav(Dismiss)`, then a delivery to the page), and the page answers with `ContentReq::Play` / `ContentReq::Present`. That dismissal is only PARKED until the commit, so `content_command`'s gate, `input_owner() == Entry(sender)`, still saw the closing surface holding input and answered `Refused`: the panel closed and nothing played or opened. Before #1392 the commands ran after the frame's commit and never met the closing surface. The five page-command gates (content, Home, Search, Watchlist, Library) now ask one read-only question of the dispatcher, `input_owner_after_dismissals`: who holds input once the Dismiss ops already parked commit. A surface that stays open still covers its page, so the covered-page refusal and RetiredSender for a dead sender are unchanged, and nothing about the FIFO, its order or its hashed state moves. Tests: the reporter's Play Version case and the Also available picker through the real dispatcher and runner (both Refused before, Completed after), a page under a picker that stays open still refused, and the container query itself. Closes #1424 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1424
What
Picking a row in Play Version (or Also available) on a Detail page closes the panel again and then
plays (or opens) what was picked. Since #1392 it closed the panel and did nothing.
A page's app commands are gated on "the sender holds input". The five page-command gates (content, Home,
Search, Watchlist, Library) now ask one read-only dispatcher question,
input_owner_after_dismissals: who holdsinput once the
Dismissops already parked this drain commit. The question only reads: no dispatcher field,FIFO order or hash input is added. What changes is the gates' outcome, so a recording that contains a pick
from a closing surface admits the command and its
state_hashmoves from there on.Why
The refusal rule (
rust-modules/src/app/content.rs:593on3878e4f55, and its four siblings at 745, 817,867 and 990): a page's command is refused unless
nav.input_owner() == Entry(sender's entry), whereinput_owner()is the topmost Opening|Open modal surface, else the top page. A covered page must notnavigate for itself.
Why this command fell foul of it:
Fx::Nav(Dismiss)then a delivery ofAppMsg::PlayVersion(screens/src/versions_panel.rs:99,113).The page answers with
ContentReq::Play(screens/src/detail/mod.rs, theAppMsg::PlayVersionarm nearline 2391 into
play_hero, line 4628). Also available is the same shape (alt_sources.rs,AppMsg::AltSourceOpenintoContentReq::Present).Dismissis only PARKED in the drain (ui/src/dispatch.rs:2531) and commits at NAV COMMIT, step 7 ofthe frame.
take_content_reqsafterbridge::frame), when thepanel was already gone. refactor(ui): complete owned presentation and replay inputs #1392 moved execution to the yielded FIFO head, in the pre-commit drain. There the
panel is still Open, still the input owner, so the live Detail page got
Refused: the panel closed, nothingplayed.
It is
Refused, notRetiredSender: the sender is the live Detail page, so this is not a dead-sender case.The refusals #1392 added for covered pages and dead senders stay.
Tests
Red first, on
3878e4f55(origin/main) plus the tests only:Green with the fix (
make test-crate C=app T=detail_panel_tests):a_picked_version_plays_that_version_though_its_panel_is_still_closing(the reporter's case): a title withtwo versions, Play Version open, Down, OK through the product frame and the real runner. The page's play
command carries the SECOND version's id and ends
Completed, the panel is gone and the Player is on top.a_picked_alternative_source_opens_that_copy_though_its_picker_is_still_closing: the same for Alsoavailable,
ContentReq::Presentof the other copy's page.a_page_under_a_picker_that_stays_open_is_still_refused: the covered-page refusal still holds; only asurface whose own
Dismissis parked counts as closed.containers::tests::the_owner_after_dismissals_is_the_page_once_the_surfaces_dismiss_is_parked(ui): thecontainer-level query.
product_runner_refuses_covered_search_and_retires_an_unmounted_sender(a covered page is refused; an unmounted sender is
RetiredSender) anda_covered_live_sender_is_not_retired_and_lifecycle_after_take_is_revalidated, both inapp/dispatch_return_tests.rs.The
PreviewStartthe Detail page asks while the panel covers it is refused before and after the fix, which isright: a covered page starts nothing.
Other callers checked
Read, not all tested:
Dismissand then report to apage, which then asks the app for a command. Both tested above.
helper (
holds_input), so they cannot disagree with the content one. Library's menu reports its pick as apage-internal request (
LibraryEdit) and aLibraryMenuSelecton the surface's unmount, neither of whichreaches the library gate while the dismissal is parked. The Watchlist menu's one command (
SetOptions)comes from the surface and is exempt from that gate.
closing_menuclause, unchanged. Itsplayer-return tests (hostsim) pass.
menu, item menu, versions, alt sources), none but those two pushes a Content/Home/Library/Search/Watchlist
command from itself. That list is not complete: settings, consent, the player overlay and the dispatcher's
own edge and click-outside
Dismisses (dispatch.rs:1351,:3049) are not in it.content.rs:614-617, and Filmography,person.rs:882) dismisses itself throughContentReq::Back→content_back(content.rs:1126). A further gated command it sends in the same drain is now refused,where
mainadmitted it. Before refactor(ui): complete owned presentation and replay inputs #1392 it was refused after the commit, and Back already stops thepreview, so this restores the older outcome.
Play Version panel opens over it (
bridge.rs:4423). A pick there is admitted because the search skips onlysurfaces whose
Dismissis parked and falls through to the copy. That was checked by reading; no teststacks two real surfaces or covers a surface still Opening.
Gates (on the committed tree,
git status --shortempty before and after)make test-crate C=appaborts with SIGSEGV (exit -11) inapp::bridge::product_extension_tests::an_unregistered_product_screen_uses_generic_navigation_and_actual_store_effectson this Mac. The same test dies the same way on the unmodified
3878e4f55(run alone:running 1 test, thenexit -11; a 64 MiBRUST_MIN_STACKdoes not change it), so it is not this change. The committed tree'stest binary with that one test skipped:
The first full run also failed
adapters::huds::tests::missing_faces_are_tried_again_after_a_store_event_and_the_package_then_compilesandbootstrap::tests::flow12_default_producer_long_recording_passes_current_preflightonce; neither recurred inthe three runs after.
Not verified
playback itself is not exercised past the Player being pushed.
command in them goes from one page to another, and none presents a surface. That was checked by reading the
recorded payloads, not by replaying them; CI's replay gate is the proof.
pr-reviewerpass ran on this commit. It found no blocker or major issue, and two minor ones: the wordingthis text now corrects, and the missing two-surface test above.
make checkaggregate was not run; the gates above are the brief's list.🤖 Generated with Claude Code