Repository navigation
Conversation
Picking Go to Movie or Go to Show in an item's hold menu ran the page under the menu to its top as the menu closed, and BACK from the opened page came back to the top instead of the card. The menu parks its own Dismiss and the app then parks the Push, both captured while the menu's row held focus. The Dismiss commits first, so by the Push the closing menu no longer owns input, and Navigation::request wrote the row's key onto the host page's return state. The host's Enter(Restored) then missed and seated its top group. A page op whose return state was captured on another entry now leaves the page its own spot, as it already did while a surface still owned input.
tiper
force-pushed
the
fix/go-to-keeps-card-focus
branch
from
November 19, 2026 12:08
e387be6 to
fa6096e
Compare
Both cases where the page keeps its own spot (a live surface took the captured one, or it was captured on a surface that has closed since) now share one fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking Go to Movie or Go to Show in an item's hold menu ran the page under the menu to its top as the menu closed, and Back from the opened page came back to the top instead of the card. Seen on Home and in the Library grid; a plain OK on the same card was fine.
Cause
The menu parks its own
Dismiss, then the app parks thePush, both captured while the menu's row held focus. Since plxnative#1392/plxnative#1433 theDismisscommits first, so by thePushthe closing menu no longer owns input, andNavigation::requestwrote the menu row's key onto the host page's return state. The host'sEnter(Restored)then missed and seated its top group.Fix
A page op whose return state was captured on another entry now leaves the page its own spot, as it already did while a surface still owned input (
rust-modules/ui/src/containers/mod.rs).Tests
a_push_parked_behind_a_surfaces_dismiss_keeps_the_hosts_return_spot(plx_ui containers): red before the fix (hostret.focusheld the menu row), green after.cargo test --lib -p plx_ui: 1750 passed.The same commit is on
up/go-to-keeps-card-focus, cut from PlxNative'smain, for the upstream PR.Generated by Claude Code