Skip to content

Go to Movie keeps the card's focus while its menu closes - #42

Closed
tiper wants to merge 2 commits into
mainfrom
fix/go-to-keeps-card-focus
Closed

tiper wants to merge 2 commits into
mainfrom
fix/go-to-keeps-card-focus

Conversation

@tiper

@tiper tiper commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Picking Go to Movie or Go to Show in an item's hold menu ran the page under the menu to its top as the menu closed, and Back from the opened page came back to the top instead of the card. Seen on Home and in the Library grid; a plain OK on the same card was fine.

Cause

The menu parks its own Dismiss, then the app parks the Push, both captured while the menu's row held focus. Since plxnative#1392/plxnative#1433 the Dismiss commits first, so by the Push the closing menu no longer owns input, and Navigation::request wrote the menu row's key onto the host page's return state. The host's Enter(Restored) then missed and seated its top group.

Fix

A page op whose return state was captured on another entry now leaves the page its own spot, as it already did while a surface still owned input (rust-modules/ui/src/containers/mod.rs).

Tests

  • New a_push_parked_behind_a_surfaces_dismiss_keeps_the_hosts_return_spot (plx_ui containers): red before the fix (host ret.focus held the menu row), green after.
  • cargo test --lib -p plx_ui: 1750 passed.
  • App crate lib tests: 1459 passed; the 7 failures are the session/TLS tests that fail only under a root container, unrelated to navigation.
  • macOS simulator against the Jellyfin mock: reproduced before the fix on Home and in the Library.

The same commit is on up/go-to-keeps-card-focus, cut from PlxNative's main, for the upstream PR.


Generated by Claude Code

Picking Go to Movie or Go to Show in an item's hold menu ran the page under the menu to its top
as the menu closed, and BACK from the opened page came back to the top instead of the card.

The menu parks its own Dismiss and the app then parks the Push, both captured while the menu's
row held focus. The Dismiss commits first, so by the Push the closing menu no longer owns input,
and Navigation::request wrote the row's key onto the host page's return state. The host's
Enter(Restored) then missed and seated its top group.

A page op whose return state was captured on another entry now leaves the page its own spot,
as it already did while a surface still owned input.
@tiper
tiper force-pushed the fix/go-to-keeps-card-focus branch from e387be6 to fa6096e Compare November 19, 2026 12:08
Both cases where the page keeps its own spot (a live surface took the captured one, or it was captured on a surface that has closed since) now share one fallback.
@tiper tiper closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant