[release-4.22] OCPBUGS-114401: gcd support by barbacbd · Pull Request #193 · openshift/machine-api-provider-gcp

barbacbd · 2026-08-26T17:42:32Z

No description provided.

Adds support for loading the universe domain from the credentials, which is necessary for any environment that does not use the default universe domain, particularly Google Cloud Dedicatged, the sovereign cloud offering. This commit also upgrades to the non-deprecated WithAuthCredentialsJSON and FromCredentialsJSONWithType. These functions take a credential type parameter, which can be used to limit accepted credentials types, which is useful for validating credentials provided by external third parties. For OpenShift, cluster credentials are coming from first party users running clusters in their project, so we do not need to limit which credentials are accepted; therefore we just pass the type through from the credential to the function.

Bring in the most up-to-date authentication packages.

go mod tidy && go mod vendor

openshift-merge-bot · 2026-08-26T17:42:36Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-26T17:42:40Z

@barbacbd: This pull request references Jira Issue OCPBUGS-114401, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-26T17:42:42Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 71dacb28-d3fd-4325-8fcd-3a000ae20579

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

barbacbd · 2026-08-26T17:43:06Z

/jira refresh

openshift-ci-robot · 2026-08-26T17:43:13Z

@barbacbd: This pull request references Jira Issue OCPBUGS-114401, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-112144 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-112144 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

barbacbd · 2026-08-31T15:57:00Z

/test e2e-gcp-ovn

barbacbd · 2026-08-31T16:02:01Z

/test e2e-gcp-operator

sadasu · 2026-08-31T19:16:46Z

/test regression-clusterinfra-gcp-ipi-mapi

rochacbruno · 2026-08-31T21:12:26Z

/test e2e-gcp-ovn

damdo

/approve
/lgtm

/verified by ci

/label backport-risk-assessed

openshift-ci-robot · 2026-09-01T10:22:40Z

@damdo: This PR has been marked as verified by ci.

Details

In response to this:

/approve
/lgtm

/verified by ci

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo · 2026-09-01T10:25:00Z

/retest

openshift-merge-bot · 2026-09-01T10:28:39Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci · 2026-09-01T10:29:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo · 2026-09-01T14:58:22Z

/test e2e-gcp-ovn

openshift-merge-bot · 2026-09-01T19:22:28Z

/retest-required

Remaining retests: 0 against base HEAD 0073bd1 and 2 for PR HEAD b1b369b in total

patrickdillon · 2026-09-02T01:30:42Z

/test e2e-gcp-ovn

barbacbd · 2026-09-02T11:19:56Z

/retest

damdo · 2026-09-02T13:00:59Z

@barbacbd @patrickdillon We are having CI wide troubles with GCP last I heard. That might be why ci/prow/e2e-gcp-ovn keeps failing?

openshift-ci · 2026-09-02T14:38:39Z

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	`b1b369b`	link	true	`/test e2e-gcp-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

patrickdillon and others added 4 commits August 26, 2026 12:58

go.mod: include lastest google api packages

6adad80

Bring in the most up-to-date authentication packages.

vendor: bump google api

a5453c1

go mod tidy && go mod vendor

Update Vendor packages.

b1b369b

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2026

openshift-ci Bot requested review from mdbooth and racheljpg August 26, 2026 17:43

patrickdillon mentioned this pull request Aug 29, 2026

OCPBUGS-114639: OCPBUGS-112550, OCPBUGS-112549: Release 4.22 GCD and KMS support openshift/installer#10783

Merged

damdo reviewed Sep 1, 2026

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 1, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 1, 2026

openshift-ci Bot assigned damdo Sep 1, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026

damdo changed the title ~~[Release 4.22] OCPBUGS-114401: gcd support~~ [release-4.22] OCPBUGS-114401: gcd support Sep 2, 2026

damdo mentioned this pull request Sep 2, 2026

[release-4.22] OCPBUGS-112265: UPSTREAM: 1250: Support Universe Domain client options (#1250) openshift/cloud-provider-gcp#141

Open

Uh oh!

Conversation

barbacbd commented Aug 26, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 26, 2026

Uh oh!

openshift-ci-robot commented Aug 26, 2026

Uh oh!

coderabbitai Bot commented Aug 26, 2026

Review skipped

Uh oh!

barbacbd commented Aug 26, 2026

Uh oh!

openshift-ci-robot commented Aug 26, 2026

Uh oh!

barbacbd commented Aug 31, 2026

Uh oh!

barbacbd commented Aug 31, 2026

Uh oh!

sadasu commented Aug 31, 2026

Uh oh!

rochacbruno commented Aug 31, 2026

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 1, 2026

Uh oh!

damdo commented Sep 1, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 1, 2026

Uh oh!

openshift-ci Bot commented Sep 1, 2026

Uh oh!

damdo commented Sep 1, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 1, 2026

Uh oh!

patrickdillon commented Sep 2, 2026

Uh oh!

barbacbd commented Sep 2, 2026

Uh oh!

damdo commented Sep 2, 2026

Uh oh!

openshift-ci Bot commented Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants