[release-4.22] OCPBUGS-112265: UPSTREAM: 1250: Support Universe Domain client options (#1250)

[patrickdillon]

Adds support for non-standard universe domains, such as Google Cloud Dedicated's sovereign clouds. Custom token sources specified in the cloud config are still preferred to maintain consistent behavior. Otherwise, FindDefaultCredentials will discover creds based on the priority defined in the SDK. The WithCredentialsJSON function is preferred as it uses a self-signed JWT--not oauth token exchange, which may fail with custom universe domains.

Manual cherry pick of #131
Need a manual cherry pick as the GCP API package version does not have WithAuthCredentialsJSON. Instead we can just use WithCredentialsJSON.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-112265, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-112141 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-112141 targets the "5.0" version, which is one of the valid target versions: 5.0.0
• bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Adds support for non-standard universe domains, such as Google Cloud Dedicated's sovereign clouds. Custom token sources specified in the cloud config are still preferred to maintain consistent behavior. Otherwise, FindDefaultCredentials will discover creds based on the priority defined in the SDK. The WithCredentialsJSON function is preferred as it uses a self-signed JWT--not oauth token exchange, which may fail with custom universe domains.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a924d50e-8038-4715-91cb-033db2c1ea36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[damdo]

/approve
/lgtm

/verified by ci

/label backport-risk-assessed

[openshift-ci-robot]

@damdo: This PR has been marked as verified by ci.

Details

In response to this:

/approve
/lgtm

/verified by ci

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 2e28a1a and 2 for PR HEAD 7f1b6fa in total

[patrickdillon]

/retest-required

[patrickdillon]

/test e2e-gcp-ovn

[damdo]

/test e2e-gcp-ovn

[damdo]

openshift/machine-api-provider-gcp#193 (comment)

[patrickdillon]

/retest-required

[patrickdillon]

/retest-required

[openshift-ci]

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	7f1b6fa	link	true	/test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.