OCPBUGS-114639: OCPBUGS-112550, OCPBUGS-112549: Release 4.22 GCD and KMS support - #10783
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-112140, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-112139, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-112140, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-112139, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bd65708 to
f5dfff6
Compare
|
/jira refresh |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-112140, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-112139, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @rochacbruno @sadasu |
|
/retest-required |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-112549, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-112549, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-112549, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is valid. 7 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-112549, which is valid. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
f5dfff6 to
d700d0f
Compare
|
/label backport-risk-assessed |
|
/pipeline required |
|
I wasn't able to reproduce the issue locally so let's give it another shot here |
1 similar comment
|
/retest-required |
|
/lgtm |
|
Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage. |
|
/skip |
|
/verified by testwith and e2e this run shows install completing |
|
@patrickdillon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
If we're doing any more testwiths here (we might not need to if this merges in a timely manner) we should include openshift/cloud-network-config-controller#264 which was left out and causing a few e2e failures |
|
/test e2e-gcp-kms-encryption |
|
/hold Some multi-pr testing is in progress. Hold can be lifted after we are happy with the results. |
|
/hold cancel multi pr test shows this pr is working correctly. Kms test is failing due to missing permission in image registry operator. need a follow up pr to that repo |
|
/testwith openshift/installer/release-4.22/e2e-gcp-kms-encryption openshift/cluster-image-registry-operator#1362 |
Ah I see, this PR doesn't add the permission, but changes the encryption to apply at creation--so the permission is not indeed needed. excellent! |
|
/override ci/prow/e2e-gcp-ovn gcp tests seem unstable right now, the other, failures look unrelated to this pr, and the other default job passed. |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-gcp-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9797dfb
into
openshift:release-4.22
|
@barbacbd: Jira Issue Verification Checks: Jira Issue OCPBUGS-114639 Jira Issue OCPBUGS-114639 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Fix included in release 4.22.0-0.nightly-2026-09-02-125503 |
This set of commits are used to backport the GCP KMS Key support and GCD installer support to 4.22