Skip to content

OCPBUGS-114639: OCPBUGS-112550, OCPBUGS-112549: Release 4.22 GCD and KMS support - #10783

Merged
openshift-merge-bot[bot] merged 28 commits into
openshift:release-4.22from
barbacbd:release-4.22-gcd-kms-support
Sep 2, 2026
Merged

OCPBUGS-114639: OCPBUGS-112550, OCPBUGS-112549: Release 4.22 GCD and KMS support#10783
openshift-merge-bot[bot] merged 28 commits into
openshift:release-4.22from
barbacbd:release-4.22-gcd-kms-support

Conversation

@barbacbd

@barbacbd barbacbd commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

This set of commits are used to backport the GCP KMS Key support and GCD installer support to 4.22

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-112140, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-112140 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-112139, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-112139 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9a9e838e-44f8-40be-906a-943bf01d7bdc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-112140, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-112140 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-112139, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-112139 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This set of commits are used to backport the GCP KMS Key support and GCD installer support to 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
barbacbd force-pushed the release-4.22-gcd-kms-support branch from bd65708 to f5dfff6 Compare August 20, 2026 19:20
@openshift-ci
openshift-ci Bot requested review from patrickdillon and tthvo August 20, 2026 19:22
@barbacbd

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-112140, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-112140 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-112139, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-112139 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo

tthvo commented Aug 20, 2026

Copy link
Copy Markdown
Member

/cc @rochacbruno @sadasu

@openshift-ci
openshift-ci Bot requested review from rochacbruno and sadasu August 20, 2026 19:43
@barbacbd

Copy link
Copy Markdown
Contributor Author

/retest-required

@barbacbd barbacbd changed the title OCPBUGS-112140, OCPBUGS-112139: Release 4.22 GCD and KMS support OCPBUGS-112550, OCPBUGS-112549: Release 4.22 GCD and KMS support Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-112550 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-112549, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-112549 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This set of commits are used to backport the GCP KMS Key support and GCD installer support to 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is invalid:

  • expected Jira Issue OCPBUGS-112550 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-112549, which is invalid:

  • expected Jira Issue OCPBUGS-112549 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-112549, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-112550, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-112140 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-112140 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

This pull request references Jira Issue OCPBUGS-112549, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-112139 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-112139 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu

sadasu commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2026
@barbacbd
barbacbd force-pushed the release-4.22-gcd-kms-support branch from f5dfff6 to d700d0f Compare August 24, 2026 10:53
@sadasu

sadasu commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@sadasu

sadasu commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/pipeline required

@patrickdillon

Copy link
Copy Markdown
Contributor

I wasn't able to reproduce the issue locally so let's give it another shot here

1 similar comment
@sadasu

sadasu commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/retest-required

@patrickdillon

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

@patrickdillon

Copy link
Copy Markdown
Contributor

/skip

@patrickdillon

Copy link
Copy Markdown
Contributor

/verified by testwith and e2e

this run shows install completing

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@patrickdillon: This PR has been marked as verified by testwith and e2e.

Details

In response to this:

/verified by testwith and e2e

this run shows install completing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon

Copy link
Copy Markdown
Contributor

If we're doing any more testwiths here (we might not need to if this merges in a timely manner) we should include openshift/cloud-network-config-controller#264 which was left out and causing a few e2e failures

@patrickdillon

Copy link
Copy Markdown
Contributor

/test e2e-gcp-kms-encryption

@sadasu sadasu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sadasu

sadasu commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/hold

Some multi-pr testing is in progress. Hold can be lifted after we are happy with the results.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2026
@patrickdillon

patrickdillon commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/hold cancel

multi pr test shows this pr is working correctly. Kms test is failing due to missing permission in image registry operator. need a follow up pr to that repo

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2026
@tthvo

tthvo commented Sep 1, 2026

Copy link
Copy Markdown
Member

/testwith openshift/installer/release-4.22/e2e-gcp-kms-encryption openshift/cluster-image-registry-operator#1362

@patrickdillon

Copy link
Copy Markdown
Contributor

/testwith openshift/installer/release-4.22/e2e-gcp-kms-encryption openshift/cluster-image-registry-operator#1362

Ah I see, this PR doesn't add the permission, but changes the encryption to apply at creation--so the permission is not indeed needed. excellent!

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 32af8e7 and 2 for PR HEAD c9a6fac in total

@patrickdillon

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-gcp-ovn

gcp tests seem unstable right now, the other, failures look unrelated to this pr, and the other default job passed.

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

gcp tests seem unstable right now, the other, failures look unrelated to this pr, and the other default job passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 9797dfb into openshift:release-4.22 Sep 2, 2026
39 of 44 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@barbacbd: Jira Issue Verification Checks: Jira Issue OCPBUGS-114639
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-114639 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This set of commits are used to backport the GCP KMS Key support and GCD installer support to 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-shared-vpc b271534 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack b271534 link false /test e2e-azurestack
ci/prow/azure-ovn-marketplace-images b271534 link false /test azure-ovn-marketplace-images
ci/prow/e2e-vsphere-ovn-devpreview b271534 link false /test e2e-vsphere-ovn-devpreview
ci/prow/e2e-azure-default-config b271534 link false /test e2e-azure-default-config
ci/prow/gcp-custom-endpoints-proxy-wif c9a6fac link false /test gcp-custom-endpoints-proxy-wif
ci/prow/e2e-gcp-xpn-dedicated-dns-project c9a6fac link false /test e2e-gcp-xpn-dedicated-dns-project
ci/prow/e2e-gcp-custom-endpoints c9a6fac link false /test e2e-gcp-custom-endpoints
ci/prow/e2e-gcp-xpn-custom-dns c9a6fac link false /test e2e-gcp-xpn-custom-dns
ci/prow/e2e-aws-ovn-heterogeneous c9a6fac link false /test e2e-aws-ovn-heterogeneous
ci/prow/e2e-gcp-ovn-byo-vpc c9a6fac link false /test e2e-gcp-ovn-byo-vpc
ci/prow/e2e-gcp-ovn-xpn c9a6fac link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-aws-ovn-imdsv2 c9a6fac link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-gcp-secureboot c9a6fac link false /test e2e-gcp-secureboot
ci/prow/e2e-aws-ovn-single-node c9a6fac link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcd-ovn-private-techpreview c9a6fac link false /test e2e-gcd-ovn-private-techpreview
ci/prow/e2e-aws-ovn-edge-zones c9a6fac link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-gcp-custom-dns c9a6fac link false /test e2e-gcp-custom-dns
ci/prow/e2e-gcp-kms-encryption c9a6fac link false /test e2e-gcp-kms-encryption

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-09-02-125503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants