Skip to content

[release-4.22] OCPBUGS-112265: CORS-4516: Support setting universe domain in client options - #138

Closed
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-131-to-release-4.22
Closed

[release-4.22] OCPBUGS-112265: CORS-4516: Support setting universe domain in client options#138
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-131-to-release-4.22

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #131

/assign patrickdillon

Adds support for non-standard universe domains, such as Google
Cloud Dedicated's sovereign clouds. Custom token sources specified
in the cloud config are still preferred to maintain consistent
behavior. Otherwise, FindDefaultCredentials will discover creds
based on the priority defined in the SDK. The WithCredentialsJSON
function is preferred as it uses a self-signed JWT--not oauth token
exchange, which may fail with custom universe domains.
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cf768bc6-1ed5-438a-9146-0d72dc7ce00a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from nrb and racheljpg August 19, 2026 19:02
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

openshift-ci-robot commented Aug 19, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-112141 has been cloned as Jira Issue OCPBUGS-112265. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-112265: CORS-4516: Support setting universe domain in client options

Details

In response to this:

This is an automated cherry-pick of #131

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-112141: CORS-4516: Support setting universe domain in client options [release-4.22] OCPBUGS-112265: CORS-4516: Support setting universe domain in client options Aug 19, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-112265, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-112141 to target a version in 5.0.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #131

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit fc3526f link true /test unit
ci/prow/okd-scos-images fc3526f link true /test okd-scos-images
ci/prow/images fc3526f link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon

Copy link
Copy Markdown

/test e2e-gcd-ovn-private-techpreview

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

@patrickdillon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test fmt
/test images
/test okd-scos-images
/test unit
/test verify-deps
/test verify-vendor-work

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn
/test regression-clusterinfra-gcp-ipi-ccm
/test verify-commits

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cloud-provider-gcp-release-4.22-fmt
pull-ci-openshift-cloud-provider-gcp-release-4.22-images
pull-ci-openshift-cloud-provider-gcp-release-4.22-okd-scos-images
pull-ci-openshift-cloud-provider-gcp-release-4.22-unit
pull-ci-openshift-cloud-provider-gcp-release-4.22-verify-commits
pull-ci-openshift-cloud-provider-gcp-release-4.22-verify-deps
pull-ci-openshift-cloud-provider-gcp-release-4.22-verify-vendor-work
Details

In response to this:

/test e2e-gcd-ovn-private-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@patrickdillon

Copy link
Copy Markdown

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@patrickdillon: This pull request references Jira Issue OCPBUGS-112265, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-112141 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-112141 targets the "5.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon

Copy link
Copy Markdown

/close
in favor of #141

@openshift-ci openshift-ci Bot closed this Aug 26, 2026
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

@patrickdillon: Closed this PR.

Details

In response to this:

/close
in favor of #141

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants