Repository navigation
Build with CMake - #48
Merged
Merged
Conversation
Omarchy's apps now build the same way: one CMakeLists.txt with the sources as a static library shared by the app and its tests, and identical bin/build, bin/test, bin/install and CI across every app. Everything the two .pro files set carries over: the modules, the resources, -fno-exceptions with link-time optimization, -Wall -Wextra, zlib and libwebp (now found through pkg-config), and the Qt 6.9 floor, with a toolchain under build/qt/ still preferred. bin/test now runs ctest, which takes the C++ suite and the Python command tests, which nothing ran before. With the environment no longer set by the script, the window-level tests run unless HYPE_GUI_TESTS=0, rather than only when it is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] No blocking issue remains in this review; the latest test-script change appears safe to merge. SummaryHype moves from qmake to CMake, shares compiled sources between the app and C++ tests, and runs both C++ and Python tests through
Reviews (8) · Last reviewed commit: "Fail the tests when ctest finds none" · Reviewed by Greptile |
A bare Arch container has no fonts, so slides painted nothing and the font picker had one family to choose from. test_trials needs the trial importer's own Python packages, which only that tooling uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bundled toolchain was prepended to the search path, which CMake searches before the environment variable, so the documented override couldn't select another Qt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The font picker folds Noto's many families into a few, and the test that it rebuilds on a font change relies on that fold being there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The core library's objects are LTO-only, so the test link says so rather than relying on the linker plugin. qt6-wayland supplies Qt's native Wayland platform plugin; without it Hype runs under XWayland. The HYPE_GUI_TESTS note now says it covers the C++ window-level tests, since test_shutdown always opens the editor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex <noreply@openai.com>
ctest -R matches test names, not Qt test functions; -V is what shows those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The package lives in omarchy-pkgs, so CI now reads the dependency list from there, and this change keeps the in-repo PKGBUILD and bin/install as they were apart from what building with CMake needs. Each test sets its own offscreen platform so a bare ctest works too, and a test whose dependency is missing fails with what to install rather than vanishing from the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 11, 2026
Merged
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ctest succeeds on an empty build directory, so a test target that stopped being registered would have turned CI green without running anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Omarchy app is moving to the same build: CMake, with the sources compiled once as a static library that the app and its tests both link, and the same
bin/build,bin/testand GitHub Actions workflow in every repository. Hype was on qmake with two.profiles listing every source twice, its tests ran only by hand, and its Python command tests weren't run by anything.CMakeLists.txtkeeps everythinghype.proset: the Qt modules, the resources,-fno-exceptionsand link-time optimization (the reason the installed binary is a quarter smaller),-Wall -Wextra, zlib and libwebp, and the Qt 6.9 floor, whichfind_packagenow enforces. The tests are now built the same way, without exceptions and with LTO, since they link the same objects. A Qt from the installer underbuild/qt/still wins over an older system Qt, andCMAKE_PREFIX_PATHreplacesHYPE_QMAKEfor picking another. libwebp is found through pkg-config, which also finds Homebrew's, so the include and library paths #46 adds for macOS shouldn't be needed on top of this.bin/testis nowctest, running two tests, each offscreen on its own so a barectestworks as well:hype_tests, the C++ suite, andhype_commands, the Python tests of the headless commands, exports and shutdown.test_trials.pystays out, since it needs the trial importer's own Python packages. The C++ tests read exported PDFs back with Qt Pdf, which Arch ships inqt6-webengine; the app builds without it, and testing without it fails with that name rather than quietly running nothing. Because the script no longer exportsHYPE_GUI_TESTS=1, the C++ window-level tests now run unlessHYPE_GUI_TESTS=0, the same default as before from the other end.The workflow builds and tests in an Arch container as an ordinary user, installing the dependencies listed by Hype's package in omarchy-pkgs, which is where packaging lives. The in-repo
pkgbuild/PKGBUILDandbin/installkeep working and gain onlycmakeandpkgconfhere; #54, on top of this, removes them. The tests need packages the omarchy-pkgs PKGBUILD doesn't list yet:qt6-webengineandpython, plus fonts to paint slides with (ttf-jetbrains-mono, Hype's default, andnoto-fonts, whose families the font picker test folds), andcmakeandpkgconfto build. CI needs omacom/omarchy-pkgs#2573, which adds them: until it lands,hype_testsfails here for want of Qt Pdf, and with that pull request's PKGBUILD this branch and every pull request on top of it pass both tests. The portal tests stay behindHYPE_PORTAL_TESTS=1, because they claim the portal's name on the session bus and must not do that on a desktop.Several open pull requests touch
hype.pro,tests/tests.proorbin/(#35, #37, #46). Their source lines need no counterpart here: a new file insrc/is picked up by the glob.🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex XHigh.