Repository navigation
Quit with Ctrl+Q - #53
Merged
Merged
Conversation
Hype had no quit key. Ctrl+Q closes the window the way its close button does, so unsaved work still asks first; a bare Q would type a letter in the editors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex <noreply@openai.com>
[Low impact] The PR appears safe to merge; the new shortcut preserves the existing close safeguards. SummaryAdds a quit shortcut through the existing window-close path.
No actionable issues were found. No runtime tests or visual capture were performed; the native Qt interface had no ready-built executable available. Reviews (1) · Last reviewed commit: "Quit with Ctrl+Q" · Reviewed by Greptile |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omarchy's apps quit from the keyboard, asking first when there is work that would be lost. Hype had no quit key at all: the only ways out were the window's close button or the compositor's close binding.
Ctrl+Q (Qt's standard Quit key) now closes the editor through
win.close(), the same path as the close button, so the existingonClosinghandler still flushes the autosave and asks before discarding unsaved changes, and leaves a presentation first. It works from the presenter view too. The bareQthe other apps use would type a letter in Hype's editors, so it isn't bound. The shortcuts overlay and the README list it.The overlay gains one row; that was not looked at on a desktop.
No CI runs here yet: master has no workflow until #48 lands, and #48's needs omacom/omarchy-pkgs#2573. Merged onto #48 with that pull request's dependencies, the tests pass.
🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex XHigh.