Skip to content

Read slide theme colors the way the window does - #49

Merged
omarchybot merged 3 commits into
masterfrom
slide-theme-colors
Nov 12, 2026
Merged

omarchybot merged 3 commits into
masterfrom
slide-theme-colors

Conversation

@omarchybot

@omarchybot omarchybot commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Since #32, Hype's window reads an Omarchy theme's colors.toml whether a color is double-quoted, single-quoted or bare, with or without a trailing note. The slides didn't: Deck::palette() and Deck::chooseTheme() kept their own pattern, which only matched double-quoted values. A theme written accent = '#ff0000' or accent = #ff0000 # note styled the window while its slides stayed on the default Tokyo Night colors, and picking it from the palette menu, or hype new --theme, recorded none of its colors in the front matter.

Both now read through one readThemeColors() beside AppTheme, so the window and the slides can't drift apart again. It returns the colors as written and in the theme's order, so recorded color_* lines keep their case and order. It also skips the empty path of a theme that isn't installed, which every render was opening and warning about.

The shared reader is stricter about what follows a value: accent = "#112233"; or "#112233" junk is no longer read, as the window already didn't. It newly accepts leading indentation.

No CI runs here yet: master has no workflow until #48 lands, and #48's needs omacom/omarchy-pkgs#2573. Merged onto #48 with that pull request's dependencies, the tests pass.

🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex XHigh.

dhh and others added 3 commits November 11, 2026 23:04
The window accepted bare, single-quoted and annotated colors in a theme's colors.toml, but the slides and the colors recorded by choosing a theme only took double-quoted ones, so such a theme styled Hype's window and left the slides on the defaults. Both now read through one function.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restoring it as an empty string would point later tests at /themes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A map sorted them by name, which reordered every color line in the front matter on a theme change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Codex <noreply@openai.com>
@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

The PR gives window and slide themes one shared readThemeColors() reader.

  • Slide decks now read the same theme colors as the app window.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["colors.toml"] --> B["readThemeColors()"]
  B --> C["AppTheme::reload()"]
  B --> D["Deck::palette()"]
  B --> E["Deck::chooseTheme()"]
  C --> F["Window colors"]
  D --> G["Slide colors"]
  E --> H["Saved color_* values"]
Loading

Reviews (1) · Last reviewed commit: "Record a chosen theme's colors in the or..." · Reviewed by Greptile

@omarchybot
omarchybot merged commit f4674e1 into master Nov 12, 2026
1 check passed
@omarchybot omarchybot mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants