Repository navigation
Read slide theme colors the way the window does - #49
Merged
Merged
Conversation
The window accepted bare, single-quoted and annotated colors in a theme's colors.toml, but the slides and the colors recorded by choosing a theme only took double-quoted ones, so such a theme styled Hype's window and left the slides on the defaults. Both now read through one function. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restoring it as an empty string would point later tests at /themes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A map sorted them by name, which reordered every color line in the front matter on a theme change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex <noreply@openai.com>
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe PR gives window and slide themes one shared
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #32, Hype's window reads an Omarchy theme's
colors.tomlwhether a color is double-quoted, single-quoted or bare, with or without a trailing note. The slides didn't:Deck::palette()andDeck::chooseTheme()kept their own pattern, which only matched double-quoted values. A theme writtenaccent = '#ff0000'oraccent = #ff0000 # notestyled the window while its slides stayed on the default Tokyo Night colors, and picking it from the palette menu, orhype new --theme, recorded none of its colors in the front matter.Both now read through one
readThemeColors()besideAppTheme, so the window and the slides can't drift apart again. It returns the colors as written and in the theme's order, so recordedcolor_*lines keep their case and order. It also skips the empty path of a theme that isn't installed, which every render was opening and warning about.The shared reader is stricter about what follows a value:
accent = "#112233";or"#112233" junkis no longer read, as the window already didn't. It newly accepts leading indentation.No CI runs here yet: master has no workflow until #48 lands, and #48's needs omacom/omarchy-pkgs#2573. Merged onto #48 with that pull request's dependencies, the tests pass.
🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex XHigh.