Skip to content

fix(closura): qualify the founder inbox by its filter menu, not the old picker - #86

Merged
nullStack65 merged 2 commits into
release/native-0.1.10from
fix/native-0.1.10-qualify-inbox-markers
Nov 18, 2026
Merged

nullStack65 merged 2 commits into
release/native-0.1.10from
fix/native-0.1.10-qualify-inbox-markers

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Problem

PR 79 renamed the founder inbox client setting from founderInboxView to founderInboxFilter and replaced the sidebar's "All threads" picker with a multi-select filter menu. The CI source guard was updated in that PR. The desktop qualification script scripts/closura/qualify-desktop-app.py wasn't. So the AppImage built from release/native-0.1.10 at 2349389883 (which includes PRs 77, 78, 79 and 82) failed marker_founder_inbox_settings and marker_founder_inbox_all_view, even though the bundle carries the feature.

Fix

The two markers now look for strings the current feature ships:

  • founder_inbox_settings checks for founderInboxFilter, the persisted setting key.
  • founder_inbox_all_view becomes founder_inbox_filter_menu. It checks for the filter menu's trigger label, "Filter threads by inbox, sender and environment". That label always renders and survives minification.

Only scripts/closura/ changes, and that folder isn't part of the app.

Verification

  • I ran the patched script on the AppImage built from 2349389883 (sha256 15a398d7eb91f91cf90a7d5c67c0c2bbf0971346c8a3b5d4db921d8e54aa40ea). failed_gates is empty.
  • With the old script, that same AppImage failed exactly the two gates above.
  • Each new marker appears in the built web client: founderInboxFilter in 2 files, the trigger label in 1. The old strings appear in 0 files.
  • The gate name marker_founder_inbox_all_view becomes marker_founder_inbox_filter_menu in new manifests. Nothing in this repo reads gate names.
  • Nothing else in scripts/ or .github/ references the old markers.

Model: claude-opus-5-5
Task: fix

🤖 Generated with Claude Code

…ld picker

PR 79 renamed the founder inbox setting to founderInboxFilter and replaced
the "All threads" picker with a filter menu, but the desktop qualification
markers still looked for the old strings, so every build after it failed
two gates despite carrying the feature.

Model: claude-opus-5-5
Task: fix
Agent: Builder

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The trigger label names the feature and always renders; the last-option note only shows in an edge case.

Model: claude-opus-5-5
Task: fix
Agent: Builder

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullStack65

Copy link
Copy Markdown
Owner Author

Independent review: the one bot round for this PR. Reviewer: a separate Claude Opus 5.5 subagent. It reviewed head 8d97258584 read-only. This is an automated technical review, not a human approval.

Result: no blockers, nothing should-fix. The reviewer confirmed:

  • PR 79 (8cab62aa05) renamed the setting and deleted SidebarInboxBar.tsx, and it updated only the CI source guard.
  • In the built web client, the new markers appear and the old ones don't.
  • Nothing else references the old markers.
  • This is the smallest fix.

One nit, taken: the reviewer suggested marking the menu by its always-rendered trigger label, "Filter threads by inbox, sender and environment", instead of an edge-case note. That change is in 305957cbc6. Rerun on the 2349389883 AppImage, failed_gates is still empty.

@nullStack65
nullStack65 merged commit 6b5fa6f into release/native-0.1.10 Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant