Repository navigation
fix(closura): qualify the founder inbox by its filter menu, not the old picker - #86
Merged
nullStack65 merged 2 commits intoNov 18, 2026
Conversation
…ld picker PR 79 renamed the founder inbox setting to founderInboxFilter and replaced the "All threads" picker with a filter menu, but the desktop qualification markers still looked for the old strings, so every build after it failed two gates despite carrying the feature. Model: claude-opus-5-5 Task: fix Agent: Builder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The trigger label names the feature and always renders; the last-option note only shows in an edge case. Model: claude-opus-5-5 Task: fix Agent: Builder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Independent review: the one bot round for this PR. Reviewer: a separate Claude Opus 5.5 subagent. It reviewed head Result: no blockers, nothing should-fix. The reviewer confirmed:
One nit, taken: the reviewer suggested marking the menu by its always-rendered trigger label, "Filter threads by inbox, sender and environment", instead of an edge-case note. That change is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR 79 renamed the founder inbox client setting from
founderInboxViewtofounderInboxFilterand replaced the sidebar's "All threads" picker with a multi-select filter menu. The CI source guard was updated in that PR. The desktop qualification scriptscripts/closura/qualify-desktop-app.pywasn't. So the AppImage built fromrelease/native-0.1.10at2349389883(which includes PRs 77, 78, 79 and 82) failedmarker_founder_inbox_settingsandmarker_founder_inbox_all_view, even though the bundle carries the feature.Fix
The two markers now look for strings the current feature ships:
founder_inbox_settingschecks forfounderInboxFilter, the persisted setting key.founder_inbox_all_viewbecomesfounder_inbox_filter_menu. It checks for the filter menu's trigger label,"Filter threads by inbox, sender and environment". That label always renders and survives minification.Only
scripts/closura/changes, and that folder isn't part of the app.Verification
2349389883(sha25615a398d7eb91f91cf90a7d5c67c0c2bbf0971346c8a3b5d4db921d8e54aa40ea).failed_gatesis empty.founderInboxFilterin 2 files, the trigger label in 1. The old strings appear in 0 files.marker_founder_inbox_all_viewbecomesmarker_founder_inbox_filter_menuin new manifests. Nothing in this repo reads gate names.scripts/or.github/references the old markers.Model: claude-opus-5-5
Task: fix
🤖 Generated with Claude Code