Repository navigation
fix(web): threads waiting on their own agents list under Working, even when pinned - #89
Conversation
…n when pinned A pinned thread waiting on its own background task or child agent stayed in Pinned at the top of the list among finished threads, reading "Waiting", instead of moving to Working. The partition sent every pinned thread to Pinned before asking whether it was working. A working pinned thread now lists under Working and returns to Pinned when it finishes; it gets the same exit grace as any other Working thread. Done, snoozed and settled threads keep their groups. A thread waiting on a person (a pending approval or question) reads "Needs you" instead of "Approval" or "Input". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Independent bot review (Claude Sonnet 5.5 via T3 delegation), head 36f86dd No blockers. The fix does what Kameron's report asks on web. I traced the paths below and ran Findings
Checked and fine
|
…even when pinned Mobile had the same order as web: every pinned thread went to Pinned before the Working check, so a pinned parent waiting on its child sat in the top list. A working thread now lists under Working pinned or not, and a thread waiting on a person reads "Needs you", matching the web sidebar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fleet build artifacts from
|
Kameron, 2026-11-18 at about 22:20 UTC: "its showing waiting in the done area instead of under working".
Cause
The thread he saw, R720's "Dis Dat fork…", waits on a delegated Sonnet child and is pinned. The sidebar sorted every pinned thread into Pinned before checking whether it was working, and the Working tracker skipped pinned threads entirely. So a pinned parent waiting on its own agents sat at the top of the list among finished threads, reading "Waiting". Unpinned threads in the same state were already listed under Working.
Fix
A pinned thread that is working counts as Working. That includes a thread waiting on its own background task or child agent. It lists under Working while that work runs and returns to Pinned when it finishes. It also gets the same 2-second exit grace as other Working threads, so it doesn't flicker out between a run and its continuation. Pinning or unpinning a thread mid-grace still ends the grace.
Done, snoozed and settled threads keep their groups. A pinned thread that's finished stays in Pinned.
A thread waiting on a person reads "Needs you" instead of "Approval" or "Input". That covers a pending approval or question on the thread or one of its subagents. The icon and color still tell the two apart, and those threads never count as Working. Waiting on a background task or child keeps its "Waiting" label, now inside Working.
Mobile gets the same rule and labels (`threadListV2.ts`, `thread-list-v2-items.tsx`), so both clients agree.
This is the fork's default whenever the Working shelf is on, which it is by default. With project folders on, there is no Working shelf, so nothing changes there.
Not in this PR
Lead's request also asked for "routed to a human as action" to read "Needs you". I didn't key on the inbox's
attentionKind: "action". Every thread a founder starts is routed to them as action by default, so all of Kameron's own finished threads would say "Needs you". The founder-inbox routing work on this branch is adding an explicit open-request signal (pendingHumanRequest/decisionRequest). Keying "Needs you" on that, once it lands, is a small follow-up.Review round
One independent bot review (Claude Sonnet 5.5 via T3 delegation) at `36f86ddefd`: no blocking findings.
Before and after (dev server, demo data)
Before, on
release/native-0.1.10: the pinned "Nightly dependency audit" is waiting on its own work (a watched PR with checks pending), yet sits in the top list beside Done threads. The approval thread reads "Approval".After: it lists under Working (still showing its pin) and goes back to Pinned when done. The finished pinned thread stays at the top, and the approval thread reads Needs you.
The waiting state in the capture comes from an SQLite fixture in the dev server's own isolated state: a watched PR with checks pending, which parks a thread exactly like a pending child agent does. That fixture only produces the visual state; the tests cover the behavior.
Tests
threadInbox.test.ts: a pinned thread gets the Working exit grace. This fails onrelease/native-0.1.10and passes with the fix.Sidebar.logic.test.ts: a pinned or unpinned thread waiting on its own work lists under Working; finished pinned threads stay Pinned; settled and snoozed threads stay put; a pinned thread waiting on an approval is not Working.vp test runon those two plusSidebar.browser.test.tsx,entities.test.tsandthreadShell.test.ts: 5 files, 152 tests passed.Opus 5.5 via Claude Code in T3 Code.
🤖 Generated with Claude Code