Repository navigation
feat(web): show who each thread came from, and filter by it - #82
Conversation
|
Independent bot review (Claude Sonnet 5.5 via T3 delegation), head 32cbb62 Scope: only this PR's commit ( No blocking findings. There are two should-fix items and four nits. The most important is the first: the machine fallback is wider than the stated rule 3. Should-fix1. Machine-owner fallback applies to threads that do have inbox fields, which contradicts rules 3 and 4. The founder chain ends with
Fix: apply the machine fallback only when the thread has no inbox: const machineFounder = inbox ? null : (founderByEnvironmentId[thread.environmentId] ?? null);Then add a test with an agent inbox, no requester/owner/parent, and a mapped machine, expecting If you meant to treat "inbox exists but names nobody" as history too, say so in the PR text and in rule 3. As written, the code and the stated rules disagree. The screenshots ("Agent threads on a machine owned by Kameron read from Kameron's agents") suggest this may be the intent, so decide which one is right. 2. The PR description is wrong about mobile. Nits3. Memoization is not protected against Sidebar re-renders.
4. The Machine owners row can drop a rapid second edit.
5. Accessibility details on the badge.
6. A cycle's result depends on traversal order. The cycle guard works ( Checked and fine
Test gaps
|
Kameron wants to tell his own and his agents' threads apart from Jeff's. Each row now carries a small sender badge (K or J, plus a bot icon for agent work, "?" when nothing says), and the filter menu gains a multi-select From section with counts: Kameron, Kameron's agents, Jeff, Jeff's agents, Unknown. The attribution helper lives in client-runtime so every client resolves it the same way: a human origin or requester names the founder; agent work takes its requester's or owner's founder, else its parent's; history with no inbox fields falls back to the machine's owner, chosen per machine in Settings > Threads > Inbox > Machine owners. Nothing is guessed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Routed agent work with no founder in its requester, owner or parent chain is now Unknown instead of the machine owner's agents: a shared machine runs both founders' agents, so that would be a guess. Also keeps the empty owner map stable across renders, reads machine owners at edit time so quick edits don't overwrite each other, and raises the contrast of the "?" badge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
298b600 to
2eddce7
Compare
|
Fleet build artifacts from
Qualification note: with the committed qualify script, this AppImage fails two founder inbox marker gates, because PR 79 renamed |
…ox-lanes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kameron (2026-11-18, about 21:27 UTC, relayed by Lead through the Thread hygiene lane): "id also like to know which threads came from me or my agents vs jeff and his and such".
This is stacked on the sidebar filter menu PR, #79, and extends that same menu instead of adding a second control. Review this PR's own commit only:
git diff 01d578e1ac..HEAD.What changed
@t3tools/client-runtime/state/thread-attribution, so every client resolves a sender the same way. Rules, in order:inbox.originorrequestedBynames that founder.requestedBy, elseowner, else its parent thread's sender. That makes it "X's agents".founderByEnvironmentId. Nothing is hard-coded.Choices worth knowing
Review round
One independent bot review (Claude Sonnet 5.5 via T3 delegation) at `32cbb62238`: no blocking findings. A Codex attempt before it hit a rate limit and reviewed nothing.
Fixed in `298b6000ca`:
Skipped: which thread inside a malformed lineage cycle gets which sender (6).
Screenshots (dev server with demo data, after the fix)
The From section with every sender kind: a thread Kameron started, an agent thread filed to Kameron, two agent threads filed to Jeff, and two unowned agent threads shown as Unknown:
Row badges: "K", "K" with a bot icon, "J" with a bot icon, and "?":
Machine owners:
Verification
vp test runonthreadAttribution.test.ts(founder, agents, parent chain listed out of order, machine fallback, Unknown, a lineage cycle),threadListFilter.logic.test.ts(From facet counts, notifications skipping From),threadInbox.test.ts,settingsSearch.test.ts,Sidebar.logic.test.tsandSidebar.browser.test.tsx: 6 files, 139 tests passed. After the review fix, the helper, filter-logic and Sidebar tests were rerun: 4 files, 102 tests passed.Opus 5.5 via Claude Code in T3 Code.
🤖 Generated with Claude Code