[Nexthop][m4062nhp] Register m4062nhp in platform mapping verification test - #1420
Closed
zackary-nexthop wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 27, 2026
Contributor
Author
|
Closing this PR because the verification test change needs to be on the same PR as the CSVs (#1419) for the CI to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Registers m4062nhp in verify_generated_files.py's platform list so platform mapping generation for it is verified in OSS CI. Also applies the pre-commit ruff-check and ruff-format fixes to the same file: builtin generics in place of typing.Dict/List, a ClassVar annotation on the supported-platforms dict, INPUT_DIR imported without the alias, and formatter line reflow. No behavior change beyond the added platform.
Split out of #1394 per review feedback. Depends on #1419 , which adds the m4062nhp CSVs this test generates from, and should land first.
Test Plan
pre-commit run --files fboss/lib/platform_mapping_v2/test/verify_generated_files.pypasses clean.