Skip to content

[Nexthop][m4062nhp] Add platform mapping and SAI agent wiring - #1394

Closed
zackary-nexthop wants to merge 2 commits into
facebook:mainfrom
nexthop-ai:zackary-nexthop.m4062nhp.platform-mapping
Closed

[Nexthop][m4062nhp] Add platform mapping and SAI agent wiring#1394
zackary-nexthop wants to merge 2 commits into
facebook:mainfrom
nexthop-ai:zackary-nexthop.m4062nhp.platform-mapping

Conversation

@zackary-nexthop

@zackary-nexthop zackary-nexthop commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Adds the platform mapping for m4062nhp: M4062nhpPlatformMapping.h/.cpp.

Also wires m4062nhp into the SAI agent (cmake/AgentPlatformsSai.cmake, SaiPlatform.cpp, SaiPlatformInit.cpp) and adds the default m4062nhp agent.conf.

The input platform mapping CSV and JSON files are in a separate PR #1419.

Test Plan

  • All 128 ports come up with correct GID/lane mapping, tested on an m4062nhp system.

@zackary-nexthop
zackary-nexthop requested review from a team as code owners July 17, 2026 22:58
@meta-cla meta-cla Bot added the CLA Signed label Jul 17, 2026
@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.m4062nhp.platform-mapping branch from d93d396 to 0324455 Compare July 17, 2026 23:02
@zackary-nexthop
zackary-nexthop requested a review from a team as a code owner July 22, 2026 11:20
@zackary-nexthop zackary-nexthop changed the title [Nexthop][m4062nhp] Add platform mapping [Nexthop][m4062nhp] Add platform mapping and SAI agent wiring Jul 22, 2026
@srikrishnagopu

srikrishnagopu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Please split the diff into three smaller diffs:

  • platform mapping python tool changes
  • csvs
  • platform mapping changes to fboss

@zackary-nexthop

zackary-nexthop commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Please split the diff into three smaller diffs:

  • platform mapping python tool changes
  • csvs
  • platform mapping changes to fboss

@srikrishnagopu I've moved the CSV and JSON files to a separate PR (#1419). However I do not understand what you mean by the platform mapping python tool changes. If this is verify_generated_files.py, adding m4062nhp to it needs to be done along with the CSV changes for the CI to pass. The rest of the changes in that file are pre-commit lints. Let me know if I'm missing anything.

@meta-codesync

meta-codesync Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@srikrishnagopu has imported this pull request. If you are a Meta employee, you can view this in D113787581.

@srikrishnagopu

Copy link
Copy Markdown
Contributor

@zackary-nexthop I landed several changes today morning for this platform which is conflicting with this current diff. Can you rebase with latest FBOSS and resubmit it please ?

@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.m4062nhp.platform-mapping branch from 4b8db6b to 671f903 Compare July 28, 2026 11:31
@facebook-github-tools

Copy link
Copy Markdown

@zackary-nexthop has updated the pull request. You must reimport the pull request before landing.

@zackary-nexthop

Copy link
Copy Markdown
Contributor Author

@zackary-nexthop I landed several changes today morning for this platform which is conflicting with this current diff. Can you rebase with latest FBOSS and resubmit it please ?

@srikrishnagopu done!

@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.m4062nhp.platform-mapping branch from 671f903 to a991b0f Compare July 28, 2026 18:00
@facebook-github-tools

Copy link
Copy Markdown

@zackary-nexthop has updated the pull request. You must reimport the pull request before landing.

@zackary-nexthop

Copy link
Copy Markdown
Contributor Author

Closing as discussed offline. This is not required anymore, thanks to the new config driven model #1419 should be enough.
Will open a separate PR for oss/agent.conf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants