Skip to content

[Nexthop][m4062nhp] Add platform mapping CSVs and JSON - #1419

Open
zackary-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:zackary-nexthop.m4062nhp.platform-mapping-csvs
Open

[Nexthop][m4062nhp] Add platform mapping CSVs and JSON#1419
zackary-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:zackary-nexthop.m4062nhp.platform-mapping-csvs

Conversation

@zackary-nexthop

@zackary-nexthop zackary-nexthop commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Adds the platform mapping input files for m4062nhp: m4062nhp_port_profile_mapping.csv, m4062nhp_static_mapping.csv, m4062nhp_si_settings.csv, and m4062nhp_profile_settings.csv, along with the generated platform_mapping.json.

Test Plan

  • Platform Mapping Generation Verification CI regenerates platform_mapping.json from the CSVs and confirms it matches the checked-in file.
  • All 128 ports come up with correct GID/lane mapping, tested on an m4062nhp system.

@zackary-nexthop
zackary-nexthop requested a review from a team as a code owner July 27, 2026 11:33
@meta-cla meta-cla Bot added the CLA Signed label Jul 27, 2026
@zackary-nexthop zackary-nexthop changed the title [Nexthop][m4062nhp] Add platform mapping CSVs [Nexthop][m4062nhp] Add platform mapping CSVs and JSON Jul 27, 2026
@zackary-nexthop zackary-nexthop changed the title [Nexthop][m4062nhp] Add platform mapping CSVs and JSON [Nexthop][m4062nhp] Add platform mapping CSVs and register in verify_generated_files.py Jul 27, 2026
@srikrishnagopu
srikrishnagopu self-requested a review July 27, 2026 17:05
@meta-codesync

meta-codesync Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@srikrishnagopu has imported this pull request. If you are a Meta employee, you can view this in D113788002.

@srikrishnagopu

Copy link
Copy Markdown
Contributor

Can you please rebase this one too and resubmit ?

@srikrishnagopu

Copy link
Copy Markdown
Contributor

This still failed and has many conflicts. Please rebase to the top and not to the stable commit

@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.m4062nhp.platform-mapping-csvs branch from 347686c to 1ce4dfb Compare July 28, 2026 18:28
@facebook-github-tools

Copy link
Copy Markdown

@zackary-nexthop has updated the pull request. You must reimport the pull request before landing.

@zackary-nexthop

Copy link
Copy Markdown
Contributor Author

@srikrishnagopu it should be good now, for both PRs. Note that I've overridden the empty CSVs that you've added, and there were a few things e.g. in the headers that didn't match. Seems to be ok by looking at other platforms, but let me know if I should do otherwise.

@srikrishnagopu

Copy link
Copy Markdown
Contributor

@zackary-nexthop PR failures on PM. Can you please check ?

@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.m4062nhp.platform-mapping-csvs branch from 1ce4dfb to 4e5ba72 Compare July 29, 2026 15:25
@facebook-github-tools

Copy link
Copy Markdown

@zackary-nexthop has updated the pull request. You must reimport the pull request before landing.

@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.m4062nhp.platform-mapping-csvs branch from 4e5ba72 to 27a9525 Compare July 29, 2026 15:42
@facebook-github-tools

Copy link
Copy Markdown

@zackary-nexthop has updated the pull request. You must reimport the pull request before landing.

@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.m4062nhp.platform-mapping-csvs branch from 27a9525 to a7d2b90 Compare July 29, 2026 15:48
@facebook-github-tools

Copy link
Copy Markdown

@zackary-nexthop has updated the pull request. You must reimport the pull request before landing.

@zackary-nexthop zackary-nexthop changed the title [Nexthop][m4062nhp] Add platform mapping CSVs and register in verify_generated_files.py [Nexthop][m4062nhp] Add platform mapping CSVs and JSON Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants