Skip to content

fix: make Drupal components lint and build with Core 4 - #189

Open
callinmullaney wants to merge 3 commits into
mainfrom
codex/fix-drupal-theme-lint
Open

callinmullaney wants to merge 3 commits into
mainfrom
codex/fix-drupal-theme-lint

Conversation

@callinmullaney

@callinmullaney callinmullaney commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes the following bugs

  • Drupal variant source passes Core 4's strict Stylelint without consumer auto-fixes: standard overflow wrapping and clipping properties, bare nested & blocks removed in place, and formatting/hex values normalized.
  • Announcement stories import the shipped star icon already used by the Twig component.
  • Two JavaScript files receive formatting-only corrections required by Core's ESLint config.
  • The existing Style Dictionary pipeline generates lint-clean short hex values natively; two full generation runs produce identical output.

Documentation Update

No consumer setup steps change; these source fixes remove the need for Sous's install-time rewriting.

How to review this PR

  • All UI Kit SCSS passes Core Stylelint 17.15.0 with no --fix.
  • Authored JavaScript passes Core ESLint (five existing unused-disable warnings).
  • Compile all 34 SCSS entrypoints with Core Sass 1.104.0 before/after: all 2,779 declarations retain order; only the requested clipping/wrapping changes and 31 equivalent hex shortenings differ.
  • Drush-generated theme with candidate Core 4.5.1/CLI 2.4.2: system install, lint, build, then lint again, without overrides or source rewriting.
  • Storybook build and a further lint run pass.
  • Repeat the fresh installation using the published patches and the new UI Kit tag.

Accessibility

The screen-reader-only utility keeps its positioning and replaces deprecated clipping with clip-path: inset(50%).

Originating work

Requested by the Sous maintainers to remove downstream Emulsify source post-processing; no separate upstream issue exists. Intended patch release: 1.9.1.

Merge strategy: squash with this fix title so the token bot's generated commit does not turn the intended 1.9.1 patch into a minor release.

@netlify

netlify Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 5667871
🔍 Latest deploy log https://app.netlify.com/projects/emulsify-ui-kit/deploys/6ae44285b8709c1dbab0b6f6
😎 Deploy Preview https://deploy-preview-189--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant