Repository navigation
fix: make generated theme tooling work without overrides - #322
Merged
Merged
Conversation
This was referenced Oct 30, 2026
Merged
Merged
callinmullaney
marked this pull request as ready for review
October 30, 2026 19:24
Contributor
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare Core 4.5.1 so generated themes can lint and build without consumer npm overrides or install-time source rewriting. The Node support floor remains >=24.13.0; the repository runtime remains .nvmrc's Node 24.18.0.
User-facing changes
Compatibility and migration impact
Update Core before removing the old glob/locutus/minimatch overrides. Preserve unrelated overrides your own project needs. Drupal filter/function registration and ordinary output remain compatible. The maintained link() helper now correctly omits falsy attributes and the internal _keys entry; a real Twig render test covers classes and these omissions. Stylelint ignore globs and generated Prettier defaults are supplied by the companion Drupal starter patch because their paths resolve relative to the theme's config file.
Internal architecture and performance
No new abstraction or runtime policy layer. Two adapter imports switch to the maintained dependency. Dead override-audit code and its configuration-content assertions are removed. No performance claim is made.
Public API and package exports
No export-map or JSON schema changes. The obsolete recommended-package-overrides-missing warning is retired because the dependency problems are fixed upstream.
Known limitations and outstanding work — do not merge yet
Release evidence
Originating work
Requested by Sous maintainers to replace downstream install-time fixes with upstream releases; no separate originating issue exists. Companion PRs: emulsify-ds/emulsify-cli#377, emulsify-ds/emulsify-ui-kit#189, emulsify-ds/emulsify-drupal#385. UI Kit is explicitly waiting for maintainer review.