Skip to content

fix: generate themes with standard lint and dependency defaults - #385

Merged
callinmullaney merged 1 commit into
mainfrom
codex/fix-generated-theme-lint
Oct 30, 2026
Merged

callinmullaney merged 1 commit into
mainfrom
codex/fix-generated-theme-lint

Conversation

@callinmullaney

@callinmullaney callinmullaney commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

This PR does the following:

  • Generated themes require Core ^4.5.1 and no longer emit npm overrides.
  • Stylelint ignores generated dist/, .out/, .coverage/, components/ and dependency files relative to the generated theme's own configuration. Shared Core supplies the matching ESLint ignores.
  • Prettier ignores the components/ mirror, and development guidance describes authored-source linting.

Related work

Companion fixes: emulsify-ds/emulsify-cli#377 and emulsify-ds/emulsify-ui-kit#189, emulsify-ds/emulsify-core#322 (Core 4.5.1). Requested by Sous maintainers to eliminate install-time source rewriting. Intended Drupal patch release: 7.3.1.

Notes

Core 4.5.1 must be published before this patch is merged or released. Root parent-theme build tooling and shipped parent assets are unchanged.

Functional Testing

  • npm run test:generated-theme
  • npm run docs:check-commands
  • npm run release:check -- --skip-smoke
  • Real SQLite Drupal 11.4.11 site: drush emulsify acceptance_theme
  • Final candidate Core 4.5.1/CLI 2.4.2 with no npm overrides: install the UI Kit branch using emulsify system install --variant drupal --all, npm run lint, npm run build, npm run lint again
  • npm run storybook-build, followed by npm run lint
  • Repeat clean installation against published patch releases and UI Kit tag

Candidate checks used npm tarballs without saving dependency changes to generated source. No generated source auto-fix or manual edits were used. Full Drupal render/favicon release smoke was not repeated locally because host Imagick is unavailable; CI has its normal release gate.

Core's final candidate now uses the maintained Forum One Drupal filter adapter, avoiding the legacy Twig/locutus dependency tree without overrides. A clean real installation of both candidate packages has zero moderate/high/critical audit findings. Public-release verification remains blocked by CLI npm authentication, Core publication and UI Kit maintainer review.

@callinmullaney
callinmullaney marked this pull request as ready for review October 30, 2026 19:32
@callinmullaney
callinmullaney merged commit 94ea5bb into main Oct 30, 2026
14 of 20 checks passed
@callinmullaney
callinmullaney deleted the codex/fix-generated-theme-lint branch October 30, 2026 19:39
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 7.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant