Repository navigation
Preserve legacy version fallback in offline replay - #643
Merged
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
October 7, 2026 09:14
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Resolve version calls before checking their history shape, matching the live executor. A legacy default consumes no history slot, so an already-recorded activity or timer can keep that position.
Owning issue: #641.
Regression coverage
Validation
Release and consumers
Workflow 2.5.1 is published at
13927608be9d4a366678a4beb477d1a3ee27a549. The normal main build 37599674154 and published verification 37601594262 pass. The independently registry-installed patch passes all 20 frozen-history cases with 216 assertions. Published Laravel 9–13 upgrade journeys pass.Server #309 is merged and published as Server 2.5.7, manifest
sha256:8a5d15512d23c63317996ca2d74e58d7cfdb59f4080850753d632008ca63af17. Both architectures and published first-run checks pass. Installed PHP/Python/Rust replay passes 31 scenarios and published schedules pass all 15 cells without findings.Waterline #146 verifies its development dependency against the patch across all databases and Laravel 9–13, without releasing unchanged runtime UI code. Sample App #147 updates both locks and the affected tuple fields. Both applications, Compose workflows and the published PHP/Python/Rust example pass. Its published amd64/arm64 development image is verified at index
sha256:037c21e2127e18a50d6d78f287055214c56614c42c462c3fc9ed3163d3e47c9c.Website #170 is deployed, with the live manifest and rendered installation commands verified. The PHP/Python/Rust wire contract is unchanged, so this fix requires no SDK release. Consumer follow-through is complete.
The regression corpus also runs its current consumers against the base implementation to prove the new history exposes the defect.
Review
Reviewed the full production change and regression coverage against
WorkflowExecutorandVersionResolver. Legacy fallback retains the shared step position without recording a marker. Recorded and fresh versions still require the marker shape. Malformed markers and actual step drift remain rejected. Wrong change IDs now use the live resolver's replay-error diagnostic.