Repository navigation
Qualify Workflow 2.5.1 embedded test dependency - #146
Merged
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
October 7, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Test embedded Waterline against published Workflow 2.5.1, which fixes legacy version fallback during query and offline replay. This is a development dependency update. Waterline's runtime code and published package are unchanged.
Follow-through for durable-workflow/workflow#641 and durable-workflow/workflow#643.
Validation
The upstream package passes 20 frozen-history cases and published Laravel 9–13 upgrade checks. Waterline's first MySQL shard-3 run and one focused retry complete 170 tests with 2,464 assertions but exceed the unchanged seven-minute limit. Both database logs report repeated redo/checkpoint pressure.
The disposable CI MySQL service now reserves and verifies 512 MiB redo capacity. The 2 GiB filesystem bound, seven-minute limit, full test inventory and durability settings remain unchanged. This setting is documented in MySQL's redo-log guide.
Local workflow trust validation and 16 policy behavior checks pass. Corrected PR qualification passes every supported database, Laravel 9–13, frontend and responsive UI check. MySQL shard 3 completes in 407.716 seconds with all 170 tests and 2,464 assertions.
Merged-main qualification also passes at
3cb1ec9c900974101a658c5b0e3e6283c9947cb7, alongside boundary, service-image and capacity checks.Review and cleanup
Reviewed the development pin and isolated CI database setup. No runtime release is required. The merged remote branch is deleted and verified absent.