Repository navigation
Ship Workflow 2.5.1 legacy replay fix in Server 2.5.7 - #309
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Pin the published Workflow 2.5.1 package at
13927608be9d4a366678a4beb477d1a3ee27a549and prepare Server 2.5.7 / Helm chart 0.1.144.Add an HTTP regression for a legacy PHP run whose timer already occupies the version call's history position. Repeated queries return the recorded state and preserve the run and history.
Generate the current Compose and Kubernetes release identities with the existing source-release synchronizer. The Composer update changes only the Workflow package.
Follow-through for durable-workflow/workflow#641 and durable-workflow/workflow#643.
Validation
Review
Reviewed the complete diff. Only the Workflow package changes in the locked dependency graph. Its production changes since 2.4.6 are the legacy query/offline replay fix and PHP schedule timeout support. The generated release identities agree with the single source manifest. The HTTP regression starts a real legacy timer wait and verifies repeated queries preserve the stored run and history.
Publication qualification
Server 2.5.7 is published at
6cb6f064e9b815d04c45bf7dc928f3db03e65e01, with manifest digestsha256:8a5d15512d23c63317996ca2d74e58d7cfdb59f4080850753d632008ca63af17. Release verification passes both architectures, bare readiness, source-free Compose, protocol catalog and anonymous chart installation. Chart 0.1.144 has digestsha256:ffb731ebb72d29bebcc4b6bba237b1f3403744697ccbea481a2f634e0f38c749.Published replay qualification passes all 31 scenarios with no findings, October 7 at 10:00:18–10:06:23 UTC. The published image supplies the runner at the full Server source commit above. Exact tuple: Server 2.5.7 at that digest, Workflow 2.5.1, Waterline 2.2.0, CLI 2.1.3, PHP SDK 2.2.3, Python SDK 2.4.2, Rust SDK 3.2.0. Actual workers execute PHP, Python and Rust replay shards. Command:
scripts/conformance/replay-published-artifacts.sh, with those exact version environment variables, running in the published image as UID/GID 1000:1000. The completed stack, volumes, dependency trees and scratch are removed.Published schedules pass all 15 required cells with zero findings. The eight Docker shards measure 14 behavior scenarios at 10:01:07–10:36:27 UTC, including cadence, pause/resume/delete, missed fires, restart recovery, CLI and SDK controls, both PHP/Python directions, invalid cron and a missing workflow type. The install-only cell uses the verified receipts from the same published tuple's replay run. The unmodified published evaluator reads those receipts and the saved shard results at 10:43:22, without repeating the measurements. Waterline installation is verified. No Waterline UI schedule interaction or Rust schedule creation is claimed.
Command:
scripts/conformance/schedules-published-artifacts.shin the published image with the five concrete component versions above, exact Server digest andDW_SCHEDULES_SHARD_CONCURRENCY=1. Supply the same-tuple published installation receipts throughDW_SCHEDULES_ARTIFACT_INSTALL_EVIDENCE. Final evaluation explicitly suppliesDW_SCHEDULES_CADENCE_EVIDENCEand reuses the completed shards.All schedule stacks, networks, volumes, dependency trees and scratch are removed. Sample App #147, Waterline #146 and website #170 are merged and verified, including Sample App image publication and the live installation defaults. Consumer follow-through for the owning defect is complete.