Repository navigation
Integrate SonarQube Cloud analysis and quality badge - #21
Merged
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
October 15, 2026 19:37
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Outcome
Use SonarQube Cloud across the product repositories as a maintained source-quality check, with accurate repository badges and meaningful review of findings.
Acceptance
Server changes are limited to a separately coordinated CI/configuration/README window. No runtime, native/shared fixture, package version or frozen actor change is part of this task.
The Sonar integration exposed the same existing PHPStan failure on all three maintained PHP/Laravel jobs:
E2bSandboxProvider.php:109checksis_array($body)again after nonemptysandboxIDvalidation has already established that fact. The invalid-response guard at the first read remains necessary.Remove only the redundant second conditional, retain malformed/missing-ID refusal and default-template metadata, and verify with fake HTTP responses plus the normal formatting/static/test matrix. No real E2B calls, provider provisioning, credentials or dependency constraints need to change. This restores the existing CI gate and unblocks the Sonar rollout in #21; it is not evidence of a customer provisioning failure.