Skip to content

Restore E2B provisioner static analysis after response narrowing #22

Closed

Description

@rmcdaniel

The Sonar integration exposed the same existing PHPStan failure on all three maintained PHP/Laravel jobs: E2bSandboxProvider.php:109 checks is_array($body) again after nonempty sandboxID validation has already established that fact. The invalid-response guard at the first read remains necessary.

Remove only the redundant second conditional, retain malformed/missing-ID refusal and default-template metadata, and verify with fake HTTP responses plus the normal formatting/static/test matrix. No real E2B calls, provider provisioning, credentials or dependency constraints need to change. This restores the existing CI gate and unblocks the Sonar rollout in #21; it is not evidence of a customer provisioning failure.

Activity

  1. rmcdaniel commented on Oct 15, 2026

    @rmcdaniel
    MemberAuthor

    Delivered through #21 / f18b0cf. The redundant guard is removed while malformed/missing sandbox identity remains refused. Five focused positive/negative response controls and the complete 85-test/293-assertion local suite pass. Exact fresh-main PHP 8.2/Laravel12, PHP8.3/Laravel12, PHP8.4/Laravel13, target-branch and Sonar checks all pass. No package version or published provider behavior claim is inferred from this source maintenance fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions