Integrate SonarQube Cloud analysis and quality badge

.github/workflows/sonar.yml

@@ -0,0 +1,31 @@
+name: SonarQube
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+permissions:
+  contents: read
+
+concurrency:
+  group: sonar-${{ github.event_name }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+  analysis:
+    name: SonarQube analysis
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6
+        with:
+          fetch-depth: 0
+          persist-credentials: false
+      - uses: SonarSource/sonarqube-scan-action@d209202bc7d53ff1cc128f7f907dac145c9d6ae9 # v8.3.0
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          args: -Dsonar.qualitygate.wait=true -Dsonar.qualitygate.timeout=300

README.md

@@ -1,5 +1,7 @@
 # Durable Workflow AI
 
+[![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=durable-workflow_ai&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=durable-workflow_ai)
+
 <p align="center">
   <a href="https://github.com/durable-workflow/ai/actions/workflows/ci.yml?query=branch%3Amain"><img src="https://github.com/durable-workflow/ai/actions/workflows/ci.yml/badge.svg?branch=main" alt="CI status"></a>
   <a href="https://packagist.org/packages/durable-workflow/ai"><img src="https://img.shields.io/packagist/v/durable-workflow/ai.svg?include_prereleases" alt="Packagist version"></a>

sonar-project.properties

@@ -0,0 +1,14 @@
+sonar.organization=durable-workflow
+sonar.projectKey=durable-workflow_ai
+sonar.projectName=ai
+sonar.sourceEncoding=UTF-8
+sonar.sources=.
+sonar.tests=.
+sonar.test.inclusions=tests/**,**/tests/**,**/*.test.*,**/*.spec.*,**/test_*.py,benchmarks/**,scripts/conformance/**
+# Dependencies, generated assets and disposable runtime/build output are not source.
+sonar.exclusions=**/vendor/**,**/node_modules/**,**/target/**,**/dist/**,**/build/**,**/storage/**,**/.venv/**,**/__pycache__/**,**/coverage/**,**/.scannerwork/**,**/.git/**,static/vendor/**,public/vendor/**,resources/js/vendor/**
+sonar.test.exclusions=**/vendor/**,**/node_modules/**,**/target/**,**/.venv/**
+# This CI job performs static analysis. Repository test/coverage gates stay required.
+# No coverage report is collected here; leave that metric unmeasured in Sonar.
+sonar.coverage.exclusions=**/*
+sonar.sca.enabled=false

src/Providers/E2bSandboxProvider.php

@@ -106,9 +106,7 @@ public function provision(array $options = []): SandboxHandle
             id: $id,
             provider: $this->name(),
             metadata: [
-                'template_id' => is_array($body)
-                    ? (string) ($body['templateID'] ?? $this->templateId)
-                    : $this->templateId,
+                'template_id' => (string) ($body['templateID'] ?? $this->templateId),
             ],
         );
     }

tests/Unit/E2bSandboxProviderTest.php

@@ -17,6 +17,7 @@
 use Illuminate\Http\Client\Factory;
 use Illuminate\Http\Client\Request;
 use InvalidArgumentException;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
 use Throwable;
@@ -64,6 +65,44 @@ public function test_provision_uses_documented_management_contract_and_bounded_t
         });
     }
 
+    #[DataProvider('invalidProvisionResponses')]
+    public function test_provision_refuses_a_response_without_a_sandbox_identity(string $body): void
+    {
+        $this->http->fake([
+            'https://api.e2b.app/sandboxes' => $this->http->response($body, 201, [
+                'Content-Type' => 'application/json',
+            ]),
+        ]);
+
+        $this->expectException(SandboxProvisionException::class);
+        $this->expectExceptionMessage('did not include sandboxID');
+        $this->provider->provision();
+    }
+
+    /** @return array<string, array{string}> */
+    public static function invalidProvisionResponses(): array
+    {
+        return [
+            'null' => ['null'],
+            'scalar' => ['"unexpected"'],
+            'missing identity' => ['{"templateID":"coding-agent"}'],
+            'empty identity' => ['{"sandboxID":""}'],
+        ];
+    }
+
+    public function test_provision_retains_configured_template_when_response_omits_it(): void
+    {
+        $this->http->fake([
+            'https://api.e2b.app/sandboxes' => $this->http->response(['sandboxID' => 'sbx-default'], 201),
+        ]);
+
+        $handle = $this->provider->provision();
+
+        $this->assertSame('sbx-default', $handle->id);
+        $this->assertSame('coding-agent', $handle->metadata['template_id']);
+        $this->http->assertSentCount(1);
+    }
+
     public function test_provision_keeps_rate_limits_and_server_failures_retryable(): void
     {
         $statuses = [429, 500, 503];