feat(hooks)!: remove post-commit hook from product (#167) - #169
Merged
Conversation
Refresh policy belongs to the orchestrator/consumer, not the generator: - graph path: loomgraph index already re-exports every run - README_AI path: release-time / manual scan-all (see #166) Removed: hooks install post-commit, hidden 'hooks run', 'hooks rerun', hooks.post_commit config section (5 modes), GH#87 install warning, _enable warning, loop-guard/tree-aware seam machinery and tests. 'uninstall post-commit' still accepted for leftover cleanup. BREAKING CHANGE: users with the hook installed → 'codeindex hooks uninstall post-commit'; refresh indexes via 'codeindex scan-all'.
This was referenced Aug 15, 2026
dreamlx
added a commit
that referenced
this pull request
Aug 15, 2026
P1 (docs, #169 residual): active user-facing surfaces still advertising the removed post-commit workflow — codeindex init's final output, README_zh.md (bullet/workflow/skill-table; EN was clean), examples/ai-integration-guide.md (whole Post-commit section + doc-only scenario), team-workflow-guide ('Three hooks'). All removed/updated; version-history mentions intentionally kept. P2 (#171): _has_js_test_files walked .venv and duplicated the skip-set — now shares _WALK_SKIP_DIRS with detect_languages (venv/.tox/.eggs pruned), uncapped-walk rationale documented. P2 (#172): leftover-hook read_text now catches OSError — status is informational, must not crash on an unreadable file.
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
产品级移除 post-commit hook（#167 决议：直接删，不留 deprecate 版）。
-1360 / +78 行。删除面：
cli_hooks.py（888→638）：_generate_post_commit_script、run_post_commit_hook（tree-aware seam）、_maybe_warn_post_commit_disabled（GH bug(hooks install): yaml enabled: false 时仍打 ✓ 不警示 — 用户以为装好实际没动 #87 提示）、隐藏hooks run、hooks rerun；SUPPORTED_HOOKS收敛为 pre-commit + pre-pushconfig.py：PostCommitConfig/HooksConfig整体删除config_help.py/init_wizard.py/cli_config.py：hooks.post_commit 参数、yaml 生成块、WizardResult 字段scan-all --retry-all保留Why
刷新时机策略归编排者/消费者，codeindex 收敛为 stateless 生成器（ADR-007 延伸）：
loomgraph index每次全量 re-export，编排者已拥有重建Migration
codeindex hooks uninstall post-commit（命令保留做存量清理）codeindex scan-all（结构秒级；--ai有 cache）hooks run→ 报错被 wrapper 的|| true吞入 log，git 不受影响Test
hooks run/rerun消失、uninstall post-commit 可用、removed param fail-loud 报 UnknownCloses #167