fix: address codex review findings on #168-#172 range - #173
Merged
Conversation
P1 (docs, #169 residual): active user-facing surfaces still advertising the removed post-commit workflow — codeindex init's final output, README_zh.md (bullet/workflow/skill-table; EN was clean), examples/ai-integration-guide.md (whole Post-commit section + doc-only scenario), team-workflow-guide ('Three hooks'). All removed/updated; version-history mentions intentionally kept. P2 (#171): _has_js_test_files walked .venv and duplicated the skip-set — now shares _WALK_SKIP_DIRS with detect_languages (venv/.tox/.eggs pruned), uncapped-walk rationale documented. P2 (#172): leftover-hook read_text now catches OSError — status is informational, must not crash on an unreadable file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex review 结果与处置
对
f67fe38..db30e0a（PR #168–#172）做了 codex review，3 findings 全部核实属实并修复；其余审查项 codex 明确"查过无发现"（#168 release 脚本、#169 符号级删除干净度、#170 ignore 不掩盖回归、#171 glob 语义、#172 backup 语义、CHANGELOG/guide 与 CLI 输出一致）。P1 — #169 文档清理漏网（4 个活跃面向用户的面）
codeindex init最终输出仍承诺 "Auto-update README_AI.md on commit"（cli_config.py）→ 改为 lint hooksREADME_zh.md3 处（feature bullet / workflow 块hooks install post-commit/ plugin skill 表行）——英文 README 在 feat(hooks)!: remove post-commit hook from product (#167) #169 已清，中文漏了 → 镜像删除；版本历史段按惯例保留examples/ai-integration-guide.md10+ 处含整个 Post-commit 章节和 doc-only scenario → 全部移除team-workflow-guide.md"Three hooks" → "Two hooks"P2 — #171
_has_js_test_fileswalk 不剪
.venv且 skip-set 与detect_languages重复 → 抽_WALK_SKIP_DIRS共享常量（venv/.tox/.eggs 剪掉）；uncapped walk 的 rationale 注释在案（init 一次性交互命令、后续 scan 反正要全树 walk）P2 — #172
hooks status可崩溃残留检测的
read_text无异常处理，不可读文件直接 crash informational 输出 →except OSError: continue新增回归测试
Verification
全套 1788 passed, 13 skipped + ruff clean（codex 环境跑不了 pytest 是它 sandbox 无 tmp 目录，本地复现为权威）