fix(test): characterization fixture copy ignores polluted README_AI (#135 residual) - #170
Merged
Merged
Conversation
…135 residual) Repo-root scan-all generates README_AI.md inside tests/fixtures/ char_graphbuffer/ (gitignored by #136, but still on local disk). The characterization copytree carried them into the scan; GH #38's enrichment-preserve logic kept the stale '<!-- enrichment: ok -->' markers across the structural rewrite and drifted the goldens. CI was green (clean checkout has no untracked files) while local runs failed permanently. ignore_patterns in the fixture copy makes the test own its pristine-input guarantee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#135was closed by #136 (option 2: gitignoretests/fixtures/char_graphbuffer/**/README_AI.md), which stops the pollution from being committed — but not from existing on local disk. A repo-rootscan-allstill regenerates those READMEs; being gitignored they are invisible togit status, yettest_graphbuffer_baseline._copy_fixturecopytrees them into the scan target. GH #38's enrichment-preserve logic then carries the stale<!-- enrichment: ok -->marker across the structural rewrite → golden drift instructural_readmes.txt/enrich_prompts.txt.Net effect: CI green, local permanently red (CI checkouts have no untracked files). This is the same failure observed pre-existing during PR #169's full-suite run.
Fix
One line: the fixture copy ignores
README_AI.md— the characterization test now owns its pristine-input guarantee instead of depending on what a developer last ran.Also removed the 4 polluted READMEs from local disk (they were untracked/gitignored, so no repo change).
Verification
pytest tests/characterization/→ 4 passed (previously 2 failed)Re-lands the residual of #135.